You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 21:39:48 UTC

[GitHub] [airflow] bbovenzi commented on a diff in pull request #25633: Allow per-timetable ordering override in grid view

bbovenzi commented on code in PR #25633:
URL: https://github.com/apache/airflow/pull/25633#discussion_r946151278


##########
airflow/www/views.py:
##########
@@ -3622,8 +3622,10 @@ def grid_data(self):
             if run_state:
                 query = query.filter(DagRun.state == run_state)
 
-            dag_runs = query.order_by(DagRun.execution_date.desc()).limit(num_runs).all()
+            ordering = (DagRun.__table__.columns[name].desc() for name in dag.timetable.run_ordering)

Review Comment:
   Should we have the UI read `ordering` in order to know when to use `data_interval_end` as a label instead of `data_interval_start`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org