You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/17 07:21:40 UTC
[GitHub] [flink] yangyichao-mango opened a new pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
yangyichao-mango opened a new pull request #12196:
URL: https://github.com/apache/flink/pull/12196
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Fix all of the broken links in Flink docs master mentioned in [[FLINK-17353](https://issues.apache.org/jira/browse/FLINK-17353)]*
## Brief change log
- *Add flink-architecture.zh.md Chinese documents matching English documents*
- *Fix all of the broken links and redirect those links to the right pages*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d49a52910495b1328a0534bc893cb506d5a0911a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594)
* 8a039dbefa98196466e3226609de0bdcb95bc19a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630550918
That is the result of check_links.sh.
找到 1 个死链接。
http://localhost:4000/zh/ops/memory/mem_detail.html
When I try to fix http://localhost:4000/zh/ops/memory/mem_detail.html, I'm blocked by three mds that are not updated to match English md.
**ops/memory/mem_setup_tm.md**
**ops/memory/mem_trouble.md**
**ops/memory/mem_migration.md**
I think we should create a new jira issue to update those mds. When that new issue is done, I can continue to fix this broken link (http://localhost:4000/zh/ops/memory/mem_detail.html).
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango removed a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d49a52910495b1328a0534bc893cb506d5a0911a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
}, {
"hash" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a039dbefa98196466e3226609de0bdcb95bc19a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744)
* 19f5ffd8eea4707770617a5349a3ef4275708a30 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630550918
That is the result of check_links.sh.
找到 1 个死链接。
http://localhost:4000/zh/ops/memory/mem_detail.html
When I try to fix http://localhost:4000/zh/ops/memory/mem_detail.html, I'm blocked by three mds that is not be updated.
**ops/memory/mem_setup_tm.md**
**ops/memory/mem_trouble.md**
**ops/memory/mem_migration.md**
I think we should create a new jira issue to update those mds. When this issue is done, I can fix this broken link (http://localhost:4000/zh/ops/memory/mem_detail.html).
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629755223
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d49a52910495b1328a0534bc893cb506d5a0911a (Sun May 17 07:23:12 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630550918
That is the result of check_links.sh.
找到 1 个死链接。
http://localhost:4000/zh/ops/memory/mem_detail.html
When I try to fix http://localhost:4000/zh/ops/memory/mem_detail.html, I'm blocked by three mds that is not be updated.
**ops/memory/mem_setup_tm.md**
**ops/memory/mem_trouble.md**
**ops/memory/mem_migration.md**
I think we should create a new jira issue to update those mds. When that new issue is done, I can continue to fix this broken link (http://localhost:4000/zh/ops/memory/mem_detail.html).
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630223902
Hi @yangyichao-mango , please fix them too. This issue is aiming to fix all the broken links to make the CRON build pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932483
> @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p ` before execute the check_links script)
@klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12196:
URL: https://github.com/apache/flink/pull/12196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932611
That is the result after execute sh docs/check_links.sh. Thx for review. @klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629922624
@yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p ` before execute the check_links script)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630192127
@klion26 That is the result of spider.log
Find 3 Broken links.
http://localhost:4000/ops/memory/mem_setup_jm.html
http://localhost:4000/zh/ops/memory/mem_detail.html
http://localhost:4000/zh/dev/user_defined_functions.html
But All of this three broken links don't belong to [[FLINK-17353](https://issues.apache.org/jira/browse/FLINK-17353)].
Do i need to Fix those broken links?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629755223
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 19f5ffd8eea4707770617a5349a3ef4275708a30 (Fri Oct 16 10:49:56 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932115
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932386
> @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p ` before execute the check_links script)
That is the result after execute sh docs/check_links.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
}, {
"hash" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1793",
"triggerID" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19f5ffd8eea4707770617a5349a3ef4275708a30 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1793)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d49a52910495b1328a0534bc893cb506d5a0911a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d49a52910495b1328a0534bc893cb506d5a0911a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango removed a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932483
> @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p ` before execute the check_links script)
@klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango closed pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango closed pull request #12196:
URL: https://github.com/apache/flink/pull/12196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango removed a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932611
That is the result after execute sh docs/check_links.sh. Thx for review. @klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630648400
Merged and created an following up issue FLINK-17807 to resolve this brocken link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango removed a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango removed a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629932386
> @yangyichao-mango thanks for your contribution. could you please share the result after execute `sh docs/check_links.sh` here (you have to execute `sh docs/build_docs.sh -p ` before execute the check_links script)
That is the result after execute sh docs/check_links.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
}, {
"hash" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1793",
"triggerID" : "19f5ffd8eea4707770617a5349a3ef4275708a30",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a039dbefa98196466e3226609de0bdcb95bc19a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744)
* 19f5ffd8eea4707770617a5349a3ef4275708a30 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1793)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d49a52910495b1328a0534bc893cb506d5a0911a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594)
* 8a039dbefa98196466e3226609de0bdcb95bc19a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629755819
cc @wuchong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-629757606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1594",
"triggerID" : "d49a52910495b1328a0534bc893cb506d5a0911a",
"triggerType" : "PUSH"
}, {
"hash" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744",
"triggerID" : "8a039dbefa98196466e3226609de0bdcb95bc19a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8a039dbefa98196466e3226609de0bdcb95bc19a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1744)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12196:
URL: https://github.com/apache/flink/pull/12196#discussion_r426228350
##########
File path: docs/concepts/flink-architecture.zh.md
##########
@@ -0,0 +1,132 @@
+---
Review comment:
This md is added for matching English flink-architecture.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong edited a comment on pull request #12196: [FLINK-17353][docs] Fix Broken links in Flink docs master
Posted by GitBox <gi...@apache.org>.
wuchong edited a comment on pull request #12196:
URL: https://github.com/apache/flink/pull/12196#issuecomment-630648400
Merged and created an following up issue FLINK-17807 to resolve this broken link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org