You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/19 18:16:50 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #11284:
[FLINK-15911][runtime] Make Flink work with NAT.
tillrohrmann commented on a change in pull request #11284: [FLINK-15911][runtime] Make Flink work with NAT.
URL: https://github.com/apache/flink/pull/11284#discussion_r395216054
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -351,21 +351,21 @@ public static TaskExecutor startTaskManager(
LOG.info("Starting TaskManager with ResourceID: {}", resourceID);
- InetAddress remoteAddress = InetAddress.getByName(rpcService.getAddress());
+ InetAddress externalAddress = InetAddress.getByName(rpcService.getAddress());
Review comment:
I think this does not work with unresolvable external addresses. Maybe we could change the e2e test to use a external hostname instead of an ip. Then the problem should hopefully surface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services