You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/06 17:46:22 UTC

[GitHub] [incubator-pinot] akshayrai removed a comment on issue #5113: [TE] added a couple of validations to check if detection is subscribed & valid; cleaned up other validations

akshayrai removed a comment on issue #5113: [TE] added a couple of validations to check if detection is subscribed & valid; cleaned up other validations
URL: https://github.com/apache/incubator-pinot/pull/5113#issuecomment-595882853
 
 
   Validations added:
   * Make sure subscription group subscribes to the detectionName while creating an alert
   * Make sure all the subscribed detections are valid
   * recipients should be configured under the EMAIL scheme params and not at the root level
   
   Validations removed:
   * type is not compulsory in subscription group
   * type is not compulsory for sub-entity alerts.
   
   Added unit tests for newly added validations

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org