You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sowo (via GitHub)" <gi...@apache.org> on 2024/03/21 10:49:27 UTC

[PR] fix: issue #27463: Mixed time series chart throw error with Elasticsearch backend [superset]

sowo opened a new pull request, #27600:
URL: https://github.com/apache/superset/pull/27600

   …rch backend
   
   ### SUMMARY
   This PR fixes issue #27463 which reports errors with Elasticsearch backends when used in Timeseries charts.
   
   ### TESTING INSTRUCTIONS
   Create Timeseries chart type with an Elasticsearch back-end and verify that no errors are thrown
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   Fixes #27463 
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: issue #27463: Mixed time series chart throw error with Elasticsearch backend [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27600:
URL: https://github.com/apache/superset/pull/27600#issuecomment-2011933883

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27600?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 59.74%. Comparing base [(`ae29427`)](https://app.codecov.io/gh/apache/superset/commit/ae294274c7da58826a309ab06356d097e98fbe0a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`11ffe45`)](https://app.codecov.io/gh/apache/superset/pull/27600?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 14 commits behind head on master.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #27600      +/-   ##
   ==========================================
   - Coverage   67.36%   59.74%   -7.62%     
   ==========================================
     Files        1909     1909              
     Lines       74744    74749       +5     
     Branches     8329     8329              
   ==========================================
   - Hits        50352    44661    -5691     
   - Misses      22342    28038    +5696     
     Partials     2050     2050              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.72% <ø> (?)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.44% <ø> (-15.79%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/27600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.67% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27600?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: issue #27463: Mixed time series chart throw error with Elasticsearch backend [superset]

Posted by "sowo (via GitHub)" <gi...@apache.org>.
sowo closed pull request #27600: fix: issue #27463: Mixed time series chart throw error with Elasticsearch backend
URL: https://github.com/apache/superset/pull/27600


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: issue #27463: Mixed time series chart throw error with Elasticsearch backend [superset]

Posted by "sowo (via GitHub)" <gi...@apache.org>.
sowo commented on PR #27600:
URL: https://github.com/apache/superset/pull/27600#issuecomment-2012646562

   Turns out in our indexes, we use a VARCHAR type for timestamps and then the time grain function cannot be resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org