You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2025/11/04 07:30:41 UTC
[PR] address warnings in capacity manager [cloudstack]
DaanHoogland opened a new pull request, #11971:
URL: https://github.com/apache/cloudstack/pull/11971
### Description
This PR cleans the CapacityManagerImpl class from compiler warning ...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
regression testing only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3658231810
<b>[SF] Trillian test result (tid-14982)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54839 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11971-t14982-kvm-ol8.zip
Smoke tests completed. 142 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 73.53 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 13.90 | test_affinity_groups.py
test_replace_acl_of_network | `Error` | 57.00 | test_global_acls.py
ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
test_03_create_vpc_domain_vpc_offering | `Error` | 161.66 | test_domain_vpc_offerings.py
test_updating_nics_on_two_shared_networks | `Error` | 1.71 | test_gateway_on_shared_networks.py
ContextSuite context=TestGatewayOnSharedNetwork>:teardown | `Error` | 3.92 | test_gateway_on_shared_networks.py
test_01_secure_vm_migration | `Error` | 133.15 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 133.16 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_disabled | `Error` | 5.84 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 306.07 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3631176330
<b>[SF] Trillian Build Failed (tid-14925)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3635731542
<b>[SF] Trillian test result (tid-14943)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62313 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11971-t14943-kvm-ol8.zip
Smoke tests completed. 138 look OK, 12 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 112.02 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 203.26 | test_internal_lb.py
test_uservm_host_control_state | `Failure` | 16.84 | test_host_control_state.py
ContextSuite context=TestHostControlState>:teardown | `Error` | 28.44 | test_host_control_state.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 45.38 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 136.69 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Error` | 65.08 | test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type | `Failure` | 111.46 | test_kubernetes_clusters.py
test_02_native_to_native_vpc_migration | `Error` | 58.33 | test_migration.py
test_01_non_strict_host_anti_affinity | `Failure` | 91.75 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 33.98 | test_nonstrict_affinity_group.py
test_02_L2_persistent_network | `Failure` | 1.89 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 21.89 | test_persistent_network.py
test_01_vpc_privategw_acl | `Failure` | 53.55 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 105.87 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 401.81 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 142.23 | test_privategw_acl.py
test_01_single_VPC_iptables_policies | `Error` | 53.72 | test_routers_iptables_default_policy.py
test_03_create_vpc_with_specified_source_nat_ip_address | `Error` | 49.37 | test_set_sourcenat.py
test_01_vpn_usage | `Error` | 1.10 | test_usage.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 366.19 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_disabled | `Error` | 1.92 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 307.08 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3648263266
<b>[SF] Trillian test result (tid-14974)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48837 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11971-t14974-kvm-ol8.zip
Smoke tests completed. 142 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 64.31 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 8.79 | test_affinity_groups.py
test_updating_nics_on_two_shared_networks | `Error` | 1.67 | test_gateway_on_shared_networks.py
ContextSuite context=TestGatewayOnSharedNetwork>:teardown | `Error` | 3.89 | test_gateway_on_shared_networks.py
ContextSuite context=TestImportAndUnmanageVolumes>:setup | `Error` | 0.00 | test_import_unmanage_volumes.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 34.08 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.10 | test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type | `Failure` | 67.80 | test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity | `Failure` | 67.84 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 23.56 | test_nonstrict_affinity_group.py
ContextSuite context=TestMigrateVMStrictTags>:setup | `Error` | 0.00 | test_vm_strict_host_tags.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.92 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3484543594
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3632474689
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3637690932
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3810483227
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3628386325
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3660150352
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#discussion_r2732519212
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -938,7 +928,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
capacity =
new CapacityVO(host.getId(), host.getDataCenterId(), host.getPodId(), host.getClusterId(), usedCpuFinal, host.getCpus().longValue() *
- host.getSpeed().longValue(), Capacity.CAPACITY_TYPE_CPU);
+ host.getSpeed(), Capacity.CAPACITY_TYPE_CPU);
Review Comment:
```suggestion
host.getSpeed() == null ? 0 : host.getSpeed(), Capacity.CAPACITY_TYPE_CPU);
```
@harikrishna-patnala ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3810800712
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3687846427
@sureshanaparti @JoaoJandre @harikrishna-patnala can you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3644130020
<b>[SF] Trillian test result (tid-14965)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11971-t14965-kvm-ol8.zip
Smoke tests completed. 146 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_replace_acl_of_network | `Error` | 1.47 | test_global_acls.py
test_01_host_tags | `Failure` | 6.30 | test_host_tags.py
test_updating_nics_on_two_shared_networks | `Error` | 1.41 | test_gateway_on_shared_networks.py
ContextSuite context=TestGatewayOnSharedNetwork>:teardown | `Error` | 3.57 | test_gateway_on_shared_networks.py
test_02_unsecure_vm_migration | `Error` | 409.14 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 409.14 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 0.01 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#discussion_r2735263238
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -938,7 +928,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
capacity =
new CapacityVO(host.getId(), host.getDataCenterId(), host.getPodId(), host.getClusterId(), usedCpuFinal, host.getCpus().longValue() *
- host.getSpeed().longValue(), Capacity.CAPACITY_TYPE_CPU);
+ host.getSpeed(), Capacity.CAPACITY_TYPE_CPU);
Review Comment:
I didnt realise it would cause NPE, even before this fix. Ignore my comment @DaanHoogland since it has been working before as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3687956867
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3484295966
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11971?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.58%. Comparing base ([`3d6cafe`](https://app.codecov.io/gh/apache/cloudstack/commit/3d6cafe1936ed2403a1031cd5ad42dd205934412?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3ec59b`](https://app.codecov.io/gh/apache/cloudstack/commit/d3ec59b94ad09ebe166ea336d29919e103a49ebe?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (3d6cafe) and HEAD (d3ec59b). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (3d6cafe) | HEAD (d3ec59b) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #11971 +/- ##
=============================================
- Coverage 17.56% 3.58% -13.99%
=============================================
Files 5909 445 -5464
Lines 529056 37532 -491524
Branches 64617 6901 -57716
=============================================
- Hits 92941 1346 -91595
+ Misses 425661 36022 -389639
+ Partials 10454 164 -10290
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11971/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11971/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11971/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11971?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3638111452
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3484758679
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#discussion_r2603127687
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -761,28 +751,28 @@ public void updateCapacityForHost(final Host host) {
}
if (so.isDynamic()) {
reservedMemory +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
- clusterRamOvercommitRatio;
+ (long) (((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
+ clusterRamOvercommitRatio);
if(vmDetails.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
reservedCpu +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
- clusterCpuOvercommitRatio;
+ (long) (((Long.parseLong(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
+ clusterCpuOvercommitRatio);
} else {
reservedCpu +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed()) / cpuOvercommitRatio) *
- clusterCpuOvercommitRatio;
+ (long) (((Long.parseLong(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * so.getSpeed()) / cpuOvercommitRatio) *
Review Comment:
Inconsistent parsing method used for cpuNumber parameter. This line uses `Long.parseLong()` while the similar code at line 718 (for used capacity calculation) uses `Integer.parseInt()` for the same parameter. For consistency and correctness, both should use the same parsing method, preferably `Integer.parseInt()` since cpuNumber is used as an integer elsewhere in the code (e.g., lines 721, 765).
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -761,28 +751,28 @@ public void updateCapacityForHost(final Host host) {
}
if (so.isDynamic()) {
reservedMemory +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
- clusterRamOvercommitRatio;
+ (long) (((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
+ clusterRamOvercommitRatio);
if(vmDetails.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
reservedCpu +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
- clusterCpuOvercommitRatio;
+ (long) (((Long.parseLong(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
Review Comment:
Inconsistent parsing method used for cpuNumber parameter. This line uses `Long.parseLong()` while the similar code at line 713 (for used capacity calculation) uses `Integer.parseInt()` for the same parameter. For consistency and correctness, both should use the same parsing method, preferably `Integer.parseInt()` since cpuNumber is used as an integer elsewhere in the code (e.g., lines 721, 765).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3660383097
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3660406390
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3484262607
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3627768850
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3663661759
<b>[SF] Trillian test result (tid-15000)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52245 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11971-t15000-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 25.70 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3637947735
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3484258117
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3631578687
<b>[SF] Trillian Build Failed (tid-14928)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3627756989
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#discussion_r2730202893
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -938,7 +928,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
capacity =
new CapacityVO(host.getId(), host.getDataCenterId(), host.getPodId(), host.getClusterId(), usedCpuFinal, host.getCpus().longValue() *
- host.getSpeed().longValue(), Capacity.CAPACITY_TYPE_CPU);
+ host.getSpeed(), Capacity.CAPACITY_TYPE_CPU);
Review Comment:
@DaanHoogland this may cause NPE right! if speed is null in the host table.
mysql> desc host;
+-----------------------+-----------------+------+-----+----------+----------------+
| Field | Type | Null | Key | Default | Extra |
+-----------------------+-----------------+------+-----+----------+----------------+
| speed | int unsigned | YES | | NULL | |
speed value can be null.
Though this may not directly cause NPE as this is in the loop of VMs and here it will be routing host entries only.
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -761,28 +751,28 @@ public void updateCapacityForHost(final Host host) {
}
if (so.isDynamic()) {
reservedMemory +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
- clusterRamOvercommitRatio;
+ (long) (((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.memory.name())) * 1024L * 1024L) / ramOvercommitRatio) *
+ clusterRamOvercommitRatio);
if(vmDetails.containsKey(UsageEventVO.DynamicParameters.cpuSpeed.name())) {
reservedCpu +=
- ((Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
- clusterCpuOvercommitRatio;
+ (long) (((Long.parseLong(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name())) * Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuSpeed.name()))) / cpuOvercommitRatio) *
Review Comment:
@DaanHoogland can you check this, there are other lines which uses parseInt()
reservedCpuCore += Integer.parseInt(vmDetails.get(UsageEventVO.DynamicParameters.cpuNumber.name()));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#discussion_r2735263238
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -938,7 +928,7 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
capacity =
new CapacityVO(host.getId(), host.getDataCenterId(), host.getPodId(), host.getClusterId(), usedCpuFinal, host.getCpus().longValue() *
- host.getSpeed().longValue(), Capacity.CAPACITY_TYPE_CPU);
+ host.getSpeed(), Capacity.CAPACITY_TYPE_CPU);
Review Comment:
I didnt realise it would cause NPE, even before. Ignore my comment @DaanHoogland since it has been working before as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3660152016
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3810475921
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3631118542
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3631120183
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3628365549
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971) **Quality Gate failed**
Failed conditions
 [4.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=11971&metric=new_coverage&view=list) (required ≥ 40%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=11971)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] address warnings in capacity manager [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11971:
URL: https://github.com/apache/cloudstack/pull/11971#issuecomment-3637697853
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org