[GitHub] [incubator-superset] michellethomas commented on issue #6523: Improving Filter Box

[GitBox <gi...@apache.org>]

michellethomas commented on issue #6523: Improving Filter Box
URL: https://github.com/apache/incubator-superset/pull/6523#issuecomment-474603456
 
 
   @mistercrunch another issue, the new filters break with filter charts on druid datasources if you don't select a metric in your filter. Metric is now not a required field, and it seems sqla datasources don't require you to have a metric, but filter boxes on druid datasource will break without a metric with `list index out of range`
   ```
   File "superset/connectors/druid/models.py", line 1150, in run_query
       order_by = list(qry['aggregations'].keys())[0]
   IndexError: list index out of range
   ```
   
   Can we also add tests for this case? 
   cc @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org