[GitHub] [hive] tarak271 commented on a diff in pull request #4612: HIVE-27628 - implement array_remove UDF in Hive

["tarak271 (via GitHub)" <gi...@apache.org>]

tarak271 commented on code in PR #4612:
URL: https://github.com/apache/hive/pull/4612#discussion_r1299736137


##########
ql/src/test/queries/clientpositive/udf_array_remove.q:
##########
@@ -0,0 +1,40 @@
+--! qt:dataset:src
+
+-- SORT_QUERY_RESULTS
+
+set hive.fetch.task.conversion=more;
+
+DESCRIBE FUNCTION array_remove;
+DESCRIBE FUNCTION EXTENDED array_remove;
+
+-- evaluates function for array of primitives

Review Comment:
   `int type element is expected at function array_remove(array<int>,int), but void is found` is thrown if we have null in second argument. so added that test case in Junit file <`runAndVerify(asList(i1, i2, i3, i4),null,null);`>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org