[jira] [Commented] (FLINK-9944) Cleanup end-to-end test poms

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555743#comment-16555743 ] 

ASF GitHub Bot commented on FLINK-9944:
---------------------------------------

zentol opened a new pull request #6421: [FLINK-9944][tests] Cleanup end-to-end test poms
URL: https://github.com/apache/flink/pull/6421
 
 
   ## What is the purpose of the change
   
   This PR addresses various issue in the E2E module poms:
   
   ## Brief change log
   
   * set several flink dependencies to `provided`
   * remote explicit `flink-core` dependency to better represent user projects
   * move common shade-plugin configuration to parent pom
   * homogenize packaging to always use shade-plugin
   * add explicit shade-plugin execution ids to all executions
   * remove unnecessary log4j dependencies
   
   
   ## Verifying this change
   
   I've started a flink-ci run: https://travis-ci.org/zentol/flink-ci/builds/408084943
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cleanup end-to-end test poms
> ----------------------------
>
>                 Key: FLINK-9944
>                 URL: https://issues.apache.org/jira/browse/FLINK-9944
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Tests
>    Affects Versions: 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> The poms for the various end-to-end modules require some attention.
> We can streamline the shade-plugin configuration by moving common elements to the parent pom.
> Most modules explicitly depend on flink-core; in the spirit of being similar to quickstart projects (i.e. the template for user-jars) we should remove this dependency. It is transitively pulled in by the API modules flink-java and flink-streaming-java.
> Other problems:
> * several flink dependencies are not set to provided
> * the datastream-allround-test has a hard-coded scala version in it's rocksdb dependency.
> * The ttl test depends on rocksdb but doesn't actually use it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)