You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Denis Magda <dm...@apache.org> on 2017/01/10 00:51:35 UTC
classnames.properties file is not updated and missed in 1.8 release
Committers, especially Anton V. and Vovan,
I’ve been looking at the following ticket [1] and found out that the issue happens simply because both
org.apache.ignite.binary.BinaryObjectBuilder
and
org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
are not added to META-INF/classnames.properties file.
However, when I build the project from scratch I don’t see the file to be updated. There is still no entries for BinaryObjectBuilder* classes. Even more, if I download 1.8 release there is not META-INF/classnames.properties file at all. Did we introduce a bug or change the logic?
[1] https://issues.apache.org/jira/browse/IGNITE-2422 <https://issues.apache.org/jira/browse/IGNITE-2422>
—
Denis
Re: classnames.properties file is not updated and missed in 1.8 release
Posted by Максим Козлов <dr...@gmail.com>.
Well, I've seen the updated ticket.
2017-01-12 1:07 GMT+03:00 Denis Magda <dm...@apache.org>:
> Well, the “classnames.properties” is not fully updated at build time. I’ve
> corrected the description of the ticket.
> https://issues.apache.org/jira/browse/IGNITE-2422 <
> https://issues.apache.org/jira/browse/IGNITE-2422>
>
> Maksim Kozlov, would you handle this? Anton V. and Vladimir O. can assist
> you going forward.
>
> —
> Denis
>
> > On Jan 9, 2017, at 10:18 PM, Alexey Kuznetsov <ak...@gridgain.com>
> wrote:
> >
> > I'm not sure about sources.
> >
> > But "mvn clean package" should generate
> > "modules/core/target/classes/META-INF/classnames.properties"
> >
> > And yes, I think we should also push "fresh" classnames.properties as one
> > of pre-release steps.
> >
> > On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <dm...@apache.org> wrote:
> >
> >> Committers, especially Anton V. and Vovan,
> >>
> >> I’ve been looking at the following ticket [1] and found out that the
> issue
> >> happens simply because both
> >>
> >> org.apache.ignite.binary.BinaryObjectBuilder
> >>
> >> and
> >>
> >> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
> >>
> >> are not added to META-INF/classnames.properties file.
> >>
> >> However, when I build the project from scratch I don’t see the file to
> be
> >> updated. There is still no entries for BinaryObjectBuilder* classes.
> Even
> >> more, if I download 1.8 release there is not
> META-INF/classnames.properties
> >> file at all. Did we introduce a bug or change the logic?
> >>
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-2422 <
> >> https://issues.apache.org/jira/browse/IGNITE-2422>
> >>
> >> —
> >> Denis
> >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
>
>
--
Best regards, Maks Kozlov
Re: classnames.properties file is not updated and missed in 1.8
release
Posted by Denis Magda <dm...@apache.org>.
Well, the “classnames.properties” is not fully updated at build time. I’ve corrected the description of the ticket.
https://issues.apache.org/jira/browse/IGNITE-2422 <https://issues.apache.org/jira/browse/IGNITE-2422>
Maksim Kozlov, would you handle this? Anton V. and Vladimir O. can assist you going forward.
—
Denis
> On Jan 9, 2017, at 10:18 PM, Alexey Kuznetsov <ak...@gridgain.com> wrote:
>
> I'm not sure about sources.
>
> But "mvn clean package" should generate
> "modules/core/target/classes/META-INF/classnames.properties"
>
> And yes, I think we should also push "fresh" classnames.properties as one
> of pre-release steps.
>
> On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <dm...@apache.org> wrote:
>
>> Committers, especially Anton V. and Vovan,
>>
>> I’ve been looking at the following ticket [1] and found out that the issue
>> happens simply because both
>>
>> org.apache.ignite.binary.BinaryObjectBuilder
>>
>> and
>>
>> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
>>
>> are not added to META-INF/classnames.properties file.
>>
>> However, when I build the project from scratch I don’t see the file to be
>> updated. There is still no entries for BinaryObjectBuilder* classes. Even
>> more, if I download 1.8 release there is not META-INF/classnames.properties
>> file at all. Did we introduce a bug or change the logic?
>>
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-2422 <
>> https://issues.apache.org/jira/browse/IGNITE-2422>
>>
>> —
>> Denis
>
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
Re: classnames.properties file is not updated and missed in 1.8 release
Posted by Alexey Kuznetsov <ak...@gridgain.com>.
I'm not sure about sources.
But "mvn clean package" should generate
"modules/core/target/classes/META-INF/classnames.properties"
And yes, I think we should also push "fresh" classnames.properties as one
of pre-release steps.
On Tue, Jan 10, 2017 at 7:51 AM, Denis Magda <dm...@apache.org> wrote:
> Committers, especially Anton V. and Vovan,
>
> I’ve been looking at the following ticket [1] and found out that the issue
> happens simply because both
>
> org.apache.ignite.binary.BinaryObjectBuilder
>
> and
>
> org.apache.ignite.internal.binary.builder.BinaryObjectBuilderImpl
>
> are not added to META-INF/classnames.properties file.
>
> However, when I build the project from scratch I don’t see the file to be
> updated. There is still no entries for BinaryObjectBuilder* classes. Even
> more, if I download 1.8 release there is not META-INF/classnames.properties
> file at all. Did we introduce a bug or change the logic?
>
>
> [1] https://issues.apache.org/jira/browse/IGNITE-2422 <
> https://issues.apache.org/jira/browse/IGNITE-2422>
>
> —
> Denis
--
Alexey Kuznetsov
GridGain Systems
www.gridgain.com