You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/06 09:07:00 UTC

[GitHub] [incubator-celeborn] zhongqiangczq commented on a diff in pull request #1145: [CELEBORN-197] in mappartition, check transportClient whether changed…

zhongqiangczq commented on code in PR #1145:
URL: https://github.com/apache/incubator-celeborn/pull/1145#discussion_r1063257138


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1462,6 +1464,7 @@ public void onFailure(Throwable e) {
     try {
       TransportClient client =
           dataClientFactory.createClient(location.getHost(), location.getPushPort(), partitionId);
+      checkClientChanged(mapKey, pushState, client);

Review Comment:
   yes it's better to create new function that wraps check logic in createClient



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org