You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "NoFacePeace (via GitHub)" <gi...@apache.org> on 2024/07/15 09:53:30 UTC
[PR] fix pulsar admin revoke subscription permission endpoint [pulsar-client-go]
NoFacePeace opened a new pull request, #1251:
URL: https://github.com/apache/pulsar-client-go/pull/1251
### Motivation
The endpoint of RevokeSubPermission does't contain `subscription`
wrong endpoint: /{property}/{namespace}/permissions/subscription/{subscription}/{role}
correct endpoint: /{property}/{namespace}/permissions/{subscription}/{role}
https://github.com/apache/pulsar/blob/88ebe785dbdab239104981453a9bd0e4a7e896d3/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java#L366
### Modifications
delete subscription
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix pulsar admin revoke subscription permission endpoint [pulsar-client-go]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #1251:
URL: https://github.com/apache/pulsar-client-go/pull/1251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix pulsar admin revoke subscription permission endpoint [pulsar-client-go]
Posted by "NoFacePeace (via GitHub)" <gi...@apache.org>.
NoFacePeace commented on PR #1251:
URL: https://github.com/apache/pulsar-client-go/pull/1251#issuecomment-2239280576
> Could you add a test for this PR?
i see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix pulsar admin revoke subscription permission endpoint [pulsar-client-go]
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #1251:
URL: https://github.com/apache/pulsar-client-go/pull/1251#issuecomment-2228688126
Could you add a test for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org