You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 06:45:55 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
HuangXingBo opened a new pull request #13759:
URL: https://github.com/apache/flink/pull/13759
## What is the purpose of the change
*This pull request Re-layer Python Operation Make it Possible to Provide only Python implementation*
## Brief change log
- *Introduce beam_operations.py as the unified entrance of operation*
- *Extract the implementations of operation functions to operations_slow.py*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05c438cf0d44def860358741ca30151d8a3dd6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157)
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #13759:
URL: https://github.com/apache/flink/pull/13759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-714994597
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d05c438cf0d44def860358741ca30151d8a3dd6a (Fri Oct 23 06:48:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19412).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259",
"triggerID" : "716291287",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05c438cf0d44def860358741ca30151d8a3dd6a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05c438cf0d44def860358741ca30151d8a3dd6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157)
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259",
"triggerID" : "716291287",
"triggerType" : "MANUAL"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "716291287",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259",
"triggerID" : "716291287",
"triggerType" : "MANUAL"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "716291287",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8259) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-716291287
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13759: [FLINK-19412][python] Re-layer Python Operation Make it Possible to Provide only Python implementation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13759:
URL: https://github.com/apache/flink/pull/13759#issuecomment-715027223
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157",
"triggerID" : "d05c438cf0d44def860358741ca30151d8a3dd6a",
"triggerType" : "PUSH"
}, {
"hash" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164",
"triggerID" : "2e62d962b92ff2c18567a80dcae46fdcfe61d10d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d05c438cf0d44def860358741ca30151d8a3dd6a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8157)
* 2e62d962b92ff2c18567a80dcae46fdcfe61d10d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8164)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org