You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (Jira)" <ji...@apache.org> on 2019/10/18 12:09:03 UTC

[jira] [Closed] (FLINK-8124) EventTimeTrigger (and other triggers) could have less specific generic types

     [ https://issues.apache.org/jira/browse/FLINK-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aljoscha Krettek closed FLINK-8124.
-----------------------------------
    Resolution: Won't Do

I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue.

I'm hestitant about changing the signature of the Triggers.

> EventTimeTrigger (and other triggers) could have less specific generic types
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-8124
>                 URL: https://issues.apache.org/jira/browse/FLINK-8124
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>            Reporter: Cristian
>            Priority: Minor
>
> When implementing custom WindowAssigners, it is possible to need different implementations of the {{Window}} class (other than {{TimeWindow}}). In such cases, it is not possible to use the existing triggers (e.g. {{EventTimeTrigger}}) because it extends from {{Trigger<Object, TimeWindow>}} which is (unnecessarily?) specific.
> It should be possible to make that class more generic by using {{EventTimeTrigger<T, W extends Window> extends Trigger<T, W>}} instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)