You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/01/21 23:51:22 UTC

[GitHub] [nifi] patricker commented on a change in pull request #4776: Add "Mailbox" property to ConsumeEWS

patricker commented on a change in pull request #4776:
URL: https://github.com/apache/nifi/pull/4776#discussion_r562273064



##########
File path: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeEWS.java
##########
@@ -107,6 +109,14 @@
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .sensitive(true)
             .build();
+    public static final PropertyDescriptor MAILBOX = new PropertyDescriptor.Builder()
+            .name("mailbox")
+            .displayName("Mailbox")
+            .description("Mailbox")
+            .required(true)

Review comment:
       If your going to make MAILBOX required, then you'll need to include a default value so that it doesn't break existing users.  Or make it not required, and adjust the code so that it works the way it used to if no MAILBOX is provided.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org