You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org> on 2011/12/10 03:34:39 UTC

[jira] [Resolved] (CASSANDRA-3605) Exception swallowing in Hex.java

     [ https://issues.apache.org/jira/browse/CASSANDRA-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-3605.
---------------------------------------

    Resolution: Invalid

As the comment notes, this exception is handled by the post-try block null check.  Throwing a RuntimeException instead would create a bug.
                
> Exception swallowing in Hex.java
> --------------------------------
>
>                 Key: CASSANDRA-3605
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3605
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0.5
>         Environment: all
>            Reporter: Zoltan Farkas
>            Priority: Minor
>
> org.apache.cassandra.utils.Hex line 94:
>             try
>             {
>                 s = stringConstructor.newInstance(0, c.length, c);
>             }
>             catch (Exception e)
>             {
>                 // Swallowing as we'll just use a copying constructor
>             }
> this code does not comply with coding standard, caught exception needs to be rethrown as RuntimeException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira