[ https://issues.apache.org/jira/browse/FELIX-5200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre De Rop updated FELIX-5200:
---------------------------------
Fix Version/s: (was: org.apache.felix.dependencymanager-r7)
org.apache.felix.dependencymanager-r8
> Factory configuration adapter not restarted
> -------------------------------------------
>
> Key: FELIX-5200
> URL: https://issues.apache.org/jira/browse/FELIX-5200
> Project: Felix
> Issue Type: Bug
> Components: Dependency Manager
> Affects Versions: org.apache.felix.dependencymanager-r1
> Reporter: Pierre De Rop
> Assignee: Pierre De Rop
> Fix For: org.apache.felix.dependencymanager-r8
>
>
> When a factory pid adapter is losing one of its required service dependencies, it is stopped, but when the lost dependency comes up again, the configuration adapter instance is not re-created and re-started.
> Example:
> * A factory configuration adapter has a required dependency on a "Required" service.
> * The factory configuration is created, the "Required" service is registered, so a factory configuration adapter INSTANCE1 is then created.
> * Now the "Required" service is unregistered: the INSTANCE1 is then stopped.
> * And when the "Required" service comes up again, then a new factory config adapter INSTANCE2 should be re-created, updated and started, But since R1 this is not the case anymore.
> The bug is located in the AbstractDecorator.stop() method, this method currently does this:
> {code}
> public void stop() {
> for (Component component : m_services.values()) {
> m_manager.remove(component);
> }
> }
> {code}
> Clearly, this is a bug because the "m_services" list is not cleared, so when the AbstractDecorator.updated(String, Dictionary) method is called again, it finds again some old stale components, and updates them instead of re-creating new adapter instances.
> In DM3, the list was correctly cleared:
> {code}
> public void stop() {
> Object[] components;
> synchronized (m_services) {
> components = m_services.values().toArray();
> m_services.clear();
> }
> for (int i = 0; i < components.length; i++) {
> m_manager.remove((Component) components[i]);
> }
> }
> {code}
> I will add a test case soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)