You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/24 04:46:17 UTC
[GitHub] [spark] sarutak opened a new pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
sarutak opened a new pull request #28627:
URL: https://github.com/apache/spark/pull/28627
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR mainly adds two things.
1. Real headless browser support for UI test
2. A test suite using headless Chrome as one instance of those browsers.
Also, for environment where Chrome and Chrome driver is not installed, `ChromeUITest` tag is added to filter out the test suite.
By default, test suites with `ChromeUITest` is disabled.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In the current master, there are two problems for UI test.
1. Lots of tests especially JavaScript related ones are done manually.
Appearance is better to be confirmed by our eyes but logic should be tested by test cases ideally.
2. Compared to the real web browsers, HtmlUnit doesn't seem to support JavaScript enough.
I added a JavaScript related test before for SPARK-31534 using HtmlUnit which is simple library based headless browser for test.
The test I added works somehow but some JavaScript related error is shown in unit-tests.log.
```
======= EXCEPTION START ========
Exception class=[net.sourceforge.htmlunit.corejs.javascript.JavaScriptException]
com.gargoylesoftware.htmlunit.ScriptException: Error: TOOLTIP: Option "sanitizeFn" provided type "window" but expected type "(null|function)". (http://192.168.1.209:60724/static/jquery-3.4.1.min.js#2)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:904)
at net.sourceforge.htmlunit.corejs.javascript.Context.call(Context.java:628)
at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.call(ContextFactory.java:515)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.callFunction(JavaScriptEngine.java:835)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.callFunction(JavaScriptEngine.java:807)
at com.gargoylesoftware.htmlunit.InteractivePage.executeJavaScriptFunctionIfPossible(InteractivePage.java:216)
at com.gargoylesoftware.htmlunit.javascript.background.JavaScriptFunctionJob.runJavaScript(JavaScriptFunctionJob.java:52)
at com.gargoylesoftware.htmlunit.javascript.background.JavaScriptExecutionJob.run(JavaScriptExecutionJob.java:102)
at com.gargoylesoftware.htmlunit.javascript.background.JavaScriptJobManagerImpl.runSingleJob(JavaScriptJobManagerImpl.java:426)
at com.gargoylesoftware.htmlunit.javascript.background.DefaultJavaScriptExecutor.run(DefaultJavaScriptExecutor.java:157)
at java.lang.Thread.run(Thread.java:748)
Caused by: net.sourceforge.htmlunit.corejs.javascript.JavaScriptException: Error: TOOLTIP: Option "sanitizeFn" provided type "window" but expected type "(null|function)". (http://192.168.1.209:60724/static/jquery-3.4.1.min.js#2)
at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpretLoop(Interpreter.java:1009)
at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:800)
at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:105)
at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:413)
at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory.doTopCall(HtmlUnitContextFactory.java:252)
at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3264)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$4.doRun(JavaScriptEngine.java:828)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:889)
... 10 more
JavaScriptException value = Error: TOOLTIP: Option "sanitizeFn" provided type "window" but expected type "(null|function)".
== CALLING JAVASCRIPT ==
function () {
throw e;
}
======= EXCEPTION END ========
```
I tried to upgrade HtmlUnit to 2.40.0 but what is worse, the test become not working even though it works on real browsers like Chrome, Safari and Firefox without error.
```
[info] UISeleniumSuite:
[info] - SPARK-31534: text for tooltip should be escaped *** FAILED *** (17 seconds, 745 milliseconds)
[info] The code passed to eventually never returned normally. Attempted 2 times over 12.910785232 seconds. Last failure message: com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: Assignment to undefined "regeneratorRuntime" in strict mode (http://192.168.1.209:62132/static/vis-timeline-graph2d.min.js#52(Function)#1)
```
To resolve those problems, it's better to support headless browser for UI test.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I tested with following patterns. Both Chrome and Chrome driver should be installed to test.
1. sbt / with default excluded tags (expect to be skipped)
`build/sbt -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.ui.ChromeUISeleniumSuite"`
2. sbt / overwrite excluded tags as `org.apache.spark.tags.ChromeUITest` (expect to be skipped)
`build/sbt -Dtest.exclude.tags="org.apache.spark.tags.ChromeUITest" -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.ui.ChromeUISeleniumSuite"`
3. sbt / overwrite excluded tags as empty string (expect to succeed)
`build/sbt -Dtest.exclude.tags= -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver "testOnly org.apache.spark.ui.ChromeUISeleniumSuite"`
4. mvn / with default excluded tags (expect to be skipped)
`build/mvn -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver83 -Dtest=none -DwildcardSuites=org.apache.spark.ui.ChromeUISeleniumSuite test`
5. mvn / overwrite excluded tags as `org.apache.spark.tags.ChromeUITest` (expect to be skipped)
`build/mvn -Dtest.exclude.tags=org.apache.spark.tags.ChromeUITest -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver83 -Dtest=none -DwildcardSuites=org.apache.spark.ui.ChromeUISeleniumSuite test`
6. mvn / overwrite excluded tags as empty string (expect to succeed)
`build/mvn -Dtest.exclude.tags= -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest=none -DwildcardSuites=org.apache.spark.ui.ChromeUISeleniumSuite test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635850832
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635622188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633178883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633237483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634981143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633189830
**[Test build #123042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123042/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634980662
**[Test build #123202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123202/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633178779
**[Test build #123042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123042/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-636082795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635805507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635804837
**[Test build #123268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123268/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633419679
**[Test build #123076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123076/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635121208
@HyukjinKwon @shaneknapp
The time limit for CI seems to be too short with Maven.
Tests for this PR has failed 9 times due to the limit.
I see [another PR](https://github.com/apache/spark/pull/28640#issuecomment-634304376) fails with the same reason.
Can we expand the limit for Maven or do you have better idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-636081608
**[Test build #123282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123282/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633586170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633414764
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633297847
**[Test build #123060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123060/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
* This patch **fails from timeout after a configured wait of `400m`**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635108758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635850797
**[Test build #123268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123268/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635190662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633237483
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635776835
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634452783
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633189860
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123042/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28627: [SPARK-31756][WEBUI] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28627:
URL: https://github.com/apache/spark/pull/28627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635867972
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634980662
**[Test build #123202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123202/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635805507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635868747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633190729
**[Test build #123052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123052/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429670896
##########
File path: dev/run-tests.py
##########
@@ -33,6 +33,9 @@
from sparktestsupport.toposort import toposort_flatten
import sparktestsupport.modules as modules
+always_excluded_tags = [
Review comment:
`always_excluded_tags` might be misleading because this should be tested in the proper environments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635621840
**[Test build #123247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429671081
##########
File path: pom.xml
##########
@@ -204,7 +204,7 @@
<leveldbjni.group>org.fusesource.leveldbjni</leveldbjni.group>
<test.java.home>${java.home}</test.java.home>
- <test.exclude.tags></test.exclude.tags>
+ <test.exclude.tags>org.apache.spark.tags.ChromeUITest</test.exclude.tags>
Review comment:
Could you add some comment before this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635800594
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123265/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635871871
**[Test build #123282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123282/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429671303
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
This looks not robust enough.
If a developer set an irrelevant tag (`ExtendedSQLTest` or `ExtendedHiveTest`), `ChromeUITest` suddenly will cause a failure in the irrelevant `Core` module.
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
This looks not robust enough.
If a developer set an irrelevant tag (`ExtendedSQLTest` or `ExtendedHiveTest`), `ChromeUITest` suddenly will cause a failure in the irrelevant `Core` module. Did I understand correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635121208
@HyukjinKwon @shaneknapp
The time limit for CI seems to be too short with Maven.
Tests for this PR has failed 9 times due to the limit.
I see [another PR](https://github.com/apache/spark/pull/28640#issuecomment-634304376) fails with the same reason.
I understand we should avoid expanding the limit as much as possible but can we expand the limit for Maven or do you have better idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shaneknapp commented on pull request #28627: [SPARK-31756][WEBUI] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
shaneknapp commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-641652740
sorry, i don't watch github for @mentions... if this is still a problem,
file a build/infra jira and assign it to me. :)
On Thu, May 28, 2020 at 11:00 PM Kousuke Saruta <no...@github.com>
wrote:
> Couldn't finish within 500m...
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/28627#issuecomment-635777121>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAMIHLDX32JFW75S7HT5DQ3RT5FPBANCNFSM4NIXL3ZA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633357514
**[Test build #123071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123071/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633357410
Test patterns are updated in the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633419679
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633417531
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635800585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635895956
It seems that we are hitting time-out still in some cases.
BTW, @sarutak . Is the following a successful run?
- https://github.com/apache/spark/pull/28627#issuecomment-635776114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635776839
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123247/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635779238
**[Test build #123265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123265/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635850848
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123268/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633586477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635850832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635621840
**[Test build #123247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633237286
**[Test build #123060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123060/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633178883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635190015
**[Test build #123224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123224/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635804837
**[Test build #123268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123268/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635622188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633189858
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633414764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635108194
**[Test build #123202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123202/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
* This patch **fails from timeout after a configured wait of `400m`**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635777121
Couldn't finish within 500m...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635804155
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633587908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633190861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635779238
**[Test build #123265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123265/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635944580
Oh. Got it, @sarutak .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635190662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635777179
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633189858
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635187943
The problem is that it's getting too long to finish each PR build .. so last time it was pretty arguable when it increased the build time IIRC. Maybe it's time to profile and reduce the testing time again .. adding @cloud-fan too FYI. Shall we increase a bit more for now since it blocks Maven testing as can be seen above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-636264811
Thanks all for the review and expanding the timeout!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633234592
**[Test build #123052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123052/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
* This patch **fails from timeout after a configured wait of `400m`**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635871871
**[Test build #123282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123282/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635800585
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633190381
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634452793
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123151/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633357747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-636082795
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635925949
> BTW, @sarutak . Is the following a successful run?
Actually, It's not.
According to the console log, it's almost finished but aborted...
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635779618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633414769
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123071/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634452783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633298016
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123060/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633357747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634978602
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635108766
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123202/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633190729
**[Test build #123052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123052/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633178779
**[Test build #123042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123042/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633420266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635779618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634335877
**[Test build #123151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123151/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635108758
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633298009
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633586170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429710040
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
It's what I intended that if developers set `test.excluded.tags` explicitly, all the tags which are intended to be excluded should be added explicitly.
But as you concerned, this change seems to break the build compatibility.
I'll submit another idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633190861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635186557
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633298009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633234751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634452469
**[Test build #123151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123151/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
* This patch **fails from timeout after a configured wait of `400m`**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633237286
**[Test build #123060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123060/testReport)** for PR 28627 at commit [`6b47fe8`](https://github.com/apache/spark/commit/6b47fe8cccca0460ec7c0db0e16c29535f1d01b8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633234751
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633236602
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635925949
> BTW, @sarutak . Is the following a successful run?
Actually, it's not.
According to the console log, it's almost finished but aborted...
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/console
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635776835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633414635
**[Test build #123071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123071/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633420266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633357514
**[Test build #123071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123071/testReport)** for PR 28627 at commit [`70d07a3`](https://github.com/apache/spark/commit/70d07a3785799e5f44e21cb9c541faaa650ad6c0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-634981143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635121208
@HyukjinKwon @shaneknapp
The time limit for CI seems to be too short for Maven.
Tests for this PR has failed 9 times due to the limit.
I see [another PR](https://github.com/apache/spark/pull/28640#issuecomment-634304376) fails with the same reason.
I understand we should avoid expanding the limit as much as possible but can we expand the limit for Maven or do you have better idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-633234752
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123052/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635800563
**[Test build #123265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123265/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635776114
**[Test build #123247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123247/testReport)** for PR 28627 at commit [`2e805ec`](https://github.com/apache/spark/commit/2e805ec3276d820935b987861ab90a042c1a8638).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28627: [SPARK-31756][WEBUI][test-maven] Add real headless browser support for UI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28627:
URL: https://github.com/apache/spark/pull/28627#issuecomment-635868747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org