You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Craig L Russell <Cr...@Sun.COM> on 2007/10/24 22:30:47 UTC
Re: svn commit: r588002 -
/openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/apache/openjpa/enhance/localizer.properties
Hi Mike,
1. I don't think the text is an improvement. What is a private
property? Should it not be:
+ Please create a setter method for this property which may be a
private \
+ method.
or,
- Please create a setter method for this property (which may be
private).
Craig
On Oct 24, 2007, at 1:22 PM, mikedd@apache.org wrote:
> Author: mikedd
> Date: Wed Oct 24 13:22:40 2007
> New Revision: 588002
>
> URL: http://svn.apache.org/viewvc?rev=588002&view=rev
> Log:
> OPENJPA-413 committing for Teresa
>
> Modified:
> openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> apache/openjpa/enhance/localizer.properties
>
> Modified: openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/
> org/apache/openjpa/enhance/localizer.properties
> URL: http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-
> kernel/src/main/resources/org/apache/openjpa/enhance/
> localizer.properties?rev=588002&r1=588001&r2=588002&view=diff
> ======================================================================
> ========
> --- openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> apache/openjpa/enhance/localizer.properties (original)
> +++ openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> apache/openjpa/enhance/localizer.properties Wed Oct 24 13:22:40 2007
> @@ -128,7 +128,8 @@
> persistent properties must have getter methods.
> property-no-setter: No setter method found for persistent property
> "{0}", and \
> bytecode analysis of the getter did not reveal a clear backing
> field. \
> - Please create a setter method for this property (it may be private).
> + Please create a setter method for this property which may be a
> private \
> + property.
> property-setter-getter-mismatch: Bytecode analysis of the setter
> and getter \
> methods for persistent property "{0}" indicates that the two
> methods \
> might be acting on different backing fields. The setter method
> assigns to \
>
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: svn commit: r588002 - /openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/apache/openjpa/enhance/localizer.properties
Posted by Patrick Linskey <pl...@gmail.com>.
We could say "Please create a setter method of any visibility for this
property."
-Patrick
On 10/24/07, Craig L Russell <Cr...@sun.com> wrote:
> Hi Mike,
>
> On Oct 24, 2007, at 5:25 PM, Michael Dick wrote:
>
> > The first time I read it I thought it was referring to property
> > "{0}", not
> > to the method, ie because the property / field was marked private,
> > you need
> > a getter / setter.
> >
> > I think I'd prefer to omit the last bit altogether, I don't think
> > it really
> > adds much to the message besides confusing us.
> >
> > property-no-setter: No setter method found for persistent property
> > "{0}",
> > and \
> > bytecode analysis of the getter did not reveal a clear
> > backing field.
> > \
> > - Please create a setter method for this property. which may
> > be a
> > private \
> > + Please create a setter method for this property.
>
> +1.
>
> Craig
> >
> > -Mike
> >
> > On 10/24/07, Albert Lee <al...@gmail.com> wrote:
> >>
> >> I agree with Craig. The "private" is referring to the setter
> >> "method", so
> >> we should change "private property" to "private method".
> >>
> >> Albert Lee.
> >>
> >> On 10/24/07, Craig L Russell <Cr...@sun.com> wrote:
> >>>
> >>> Hi Mike,
> >>>
> >>> 1. I don't think the text is an improvement. What is a private
> >>> property? Should it not be:
> >>>
> >>> + Please create a setter method for this property which may
> >>> be a
> >>> private \
> >>> + method.
> >>>
> >>> or,
> >>> - Please create a setter method for this property (which
> >>> may be
> >>> private).
> >>>
> >>> Craig
> >>>
> >>> On Oct 24, 2007, at 1:22 PM, mikedd@apache.org wrote:
> >>>
> >>>> Author: mikedd
> >>>> Date: Wed Oct 24 13:22:40 2007
> >>>> New Revision: 588002
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=588002&view=rev
> >>>> Log:
> >>>> OPENJPA-413 committing for Teresa
> >>>>
> >>>> Modified:
> >>>> openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> >>>> apache/openjpa/enhance/localizer.properties
> >>>>
> >>>> Modified: openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/
> >>>> org/apache/openjpa/enhance/localizer.properties
> >>>> URL: http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-
> >>>> kernel/src/main/resources/org/apache/openjpa/enhance/
> >>>> localizer.properties?rev=588002&r1=588001&r2=588002&view=diff
> >>>> ===================================================================
> >>>> ===
> >>>> ========
> >>>> --- openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> >>>> apache/openjpa/enhance/localizer.properties (original)
> >>>> +++ openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> >>>> apache/openjpa/enhance/localizer.properties Wed Oct 24 13:22:40
> >>>> 2007
> >>>> @@ -128,7 +128,8 @@
> >>>> persistent properties must have getter methods.
> >>>> property-no-setter: No setter method found for persistent property
> >>>> "{0}", and \
> >>>> bytecode analysis of the getter did not reveal a clear
> >>>> backing
> >>>> field. \
> >>>> - Please create a setter method for this property (it may be
> >>> private).
> >>>> + Please create a setter method for this property which may
> >>>> be a
> >>>> private \
> >>>> + property.
> >>>> property-setter-getter-mismatch: Bytecode analysis of the setter
> >>>> and getter \
> >>>> methods for persistent property "{0}" indicates that the two
> >>>> methods \
> >>>> might be acting on different backing fields. The setter
> >>>> method
> >>>> assigns to \
> >>>>
> >>>>
> >>>
> >>> Craig Russell
> >>> Architect, Sun Java Enterprise System http://java.sun.com/
> >>> products/jdo
> >>> 408 276-5638 mailto:Craig.Russell@sun.com
> >>> P.S. A good JDO? O, Gasp!
> >>>
> >>>
> >>>
> >>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
>
>
--
Patrick Linskey
202 669 5907
Re: svn commit: r588002 -
/openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/apache/openjpa/enhance/localizer.properties
Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Mike,
On Oct 24, 2007, at 5:25 PM, Michael Dick wrote:
> The first time I read it I thought it was referring to property
> "{0}", not
> to the method, ie because the property / field was marked private,
> you need
> a getter / setter.
>
> I think I'd prefer to omit the last bit altogether, I don't think
> it really
> adds much to the message besides confusing us.
>
> property-no-setter: No setter method found for persistent property
> "{0}",
> and \
> bytecode analysis of the getter did not reveal a clear
> backing field.
> \
> - Please create a setter method for this property. which may
> be a
> private \
> + Please create a setter method for this property.
+1.
Craig
>
> -Mike
>
> On 10/24/07, Albert Lee <al...@gmail.com> wrote:
>>
>> I agree with Craig. The "private" is referring to the setter
>> "method", so
>> we should change "private property" to "private method".
>>
>> Albert Lee.
>>
>> On 10/24/07, Craig L Russell <Cr...@sun.com> wrote:
>>>
>>> Hi Mike,
>>>
>>> 1. I don't think the text is an improvement. What is a private
>>> property? Should it not be:
>>>
>>> + Please create a setter method for this property which may
>>> be a
>>> private \
>>> + method.
>>>
>>> or,
>>> - Please create a setter method for this property (which
>>> may be
>>> private).
>>>
>>> Craig
>>>
>>> On Oct 24, 2007, at 1:22 PM, mikedd@apache.org wrote:
>>>
>>>> Author: mikedd
>>>> Date: Wed Oct 24 13:22:40 2007
>>>> New Revision: 588002
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=588002&view=rev
>>>> Log:
>>>> OPENJPA-413 committing for Teresa
>>>>
>>>> Modified:
>>>> openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
>>>> apache/openjpa/enhance/localizer.properties
>>>>
>>>> Modified: openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/
>>>> org/apache/openjpa/enhance/localizer.properties
>>>> URL: http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-
>>>> kernel/src/main/resources/org/apache/openjpa/enhance/
>>>> localizer.properties?rev=588002&r1=588001&r2=588002&view=diff
>>>> ===================================================================
>>>> ===
>>>> ========
>>>> --- openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
>>>> apache/openjpa/enhance/localizer.properties (original)
>>>> +++ openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
>>>> apache/openjpa/enhance/localizer.properties Wed Oct 24 13:22:40
>>>> 2007
>>>> @@ -128,7 +128,8 @@
>>>> persistent properties must have getter methods.
>>>> property-no-setter: No setter method found for persistent property
>>>> "{0}", and \
>>>> bytecode analysis of the getter did not reveal a clear
>>>> backing
>>>> field. \
>>>> - Please create a setter method for this property (it may be
>>> private).
>>>> + Please create a setter method for this property which may
>>>> be a
>>>> private \
>>>> + property.
>>>> property-setter-getter-mismatch: Bytecode analysis of the setter
>>>> and getter \
>>>> methods for persistent property "{0}" indicates that the two
>>>> methods \
>>>> might be acting on different backing fields. The setter
>>>> method
>>>> assigns to \
>>>>
>>>>
>>>
>>> Craig Russell
>>> Architect, Sun Java Enterprise System http://java.sun.com/
>>> products/jdo
>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>> P.S. A good JDO? O, Gasp!
>>>
>>>
>>>
>>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: svn commit: r588002 - /openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/apache/openjpa/enhance/localizer.properties
Posted by Michael Dick <mi...@gmail.com>.
The first time I read it I thought it was referring to property "{0}", not
to the method, ie because the property / field was marked private, you need
a getter / setter.
I think I'd prefer to omit the last bit altogether, I don't think it really
adds much to the message besides confusing us.
property-no-setter: No setter method found for persistent property "{0}",
and \
bytecode analysis of the getter did not reveal a clear backing field.
\
- Please create a setter method for this property. which may be a
private \
+ Please create a setter method for this property.
-Mike
On 10/24/07, Albert Lee <al...@gmail.com> wrote:
>
> I agree with Craig. The "private" is referring to the setter "method", so
> we should change "private property" to "private method".
>
> Albert Lee.
>
> On 10/24/07, Craig L Russell <Cr...@sun.com> wrote:
> >
> > Hi Mike,
> >
> > 1. I don't think the text is an improvement. What is a private
> > property? Should it not be:
> >
> > + Please create a setter method for this property which may be a
> > private \
> > + method.
> >
> > or,
> > - Please create a setter method for this property (which may be
> > private).
> >
> > Craig
> >
> > On Oct 24, 2007, at 1:22 PM, mikedd@apache.org wrote:
> >
> > > Author: mikedd
> > > Date: Wed Oct 24 13:22:40 2007
> > > New Revision: 588002
> > >
> > > URL: http://svn.apache.org/viewvc?rev=588002&view=rev
> > > Log:
> > > OPENJPA-413 committing for Teresa
> > >
> > > Modified:
> > > openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > > apache/openjpa/enhance/localizer.properties
> > >
> > > Modified: openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/
> > > org/apache/openjpa/enhance/localizer.properties
> > > URL: http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-
> > > kernel/src/main/resources/org/apache/openjpa/enhance/
> > > localizer.properties?rev=588002&r1=588001&r2=588002&view=diff
> > > ======================================================================
> > > ========
> > > --- openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > > apache/openjpa/enhance/localizer.properties (original)
> > > +++ openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > > apache/openjpa/enhance/localizer.properties Wed Oct 24 13:22:40 2007
> > > @@ -128,7 +128,8 @@
> > > persistent properties must have getter methods.
> > > property-no-setter: No setter method found for persistent property
> > > "{0}", and \
> > > bytecode analysis of the getter did not reveal a clear backing
> > > field. \
> > > - Please create a setter method for this property (it may be
> > private).
> > > + Please create a setter method for this property which may be a
> > > private \
> > > + property.
> > > property-setter-getter-mismatch: Bytecode analysis of the setter
> > > and getter \
> > > methods for persistent property "{0}" indicates that the two
> > > methods \
> > > might be acting on different backing fields. The setter method
> > > assigns to \
> > >
> > >
> >
> > Craig Russell
> > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> > 408 276-5638 mailto:Craig.Russell@sun.com
> > P.S. A good JDO? O, Gasp!
> >
> >
> >
>
Re: svn commit: r588002 - /openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/apache/openjpa/enhance/localizer.properties
Posted by Albert Lee <al...@gmail.com>.
I agree with Craig. The "private" is referring to the setter "method", so
we should change "private property" to "private method".
Albert Lee.
On 10/24/07, Craig L Russell <Cr...@sun.com> wrote:
>
> Hi Mike,
>
> 1. I don't think the text is an improvement. What is a private
> property? Should it not be:
>
> + Please create a setter method for this property which may be a
> private \
> + method.
>
> or,
> - Please create a setter method for this property (which may be
> private).
>
> Craig
>
> On Oct 24, 2007, at 1:22 PM, mikedd@apache.org wrote:
>
> > Author: mikedd
> > Date: Wed Oct 24 13:22:40 2007
> > New Revision: 588002
> >
> > URL: http://svn.apache.org/viewvc?rev=588002&view=rev
> > Log:
> > OPENJPA-413 committing for Teresa
> >
> > Modified:
> > openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > apache/openjpa/enhance/localizer.properties
> >
> > Modified: openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/
> > org/apache/openjpa/enhance/localizer.properties
> > URL: http://svn.apache.org/viewvc/openjpa/branches/1.0.x/openjpa-
> > kernel/src/main/resources/org/apache/openjpa/enhance/
> > localizer.properties?rev=588002&r1=588001&r2=588002&view=diff
> > ======================================================================
> > ========
> > --- openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > apache/openjpa/enhance/localizer.properties (original)
> > +++ openjpa/branches/1.0.x/openjpa-kernel/src/main/resources/org/
> > apache/openjpa/enhance/localizer.properties Wed Oct 24 13:22:40 2007
> > @@ -128,7 +128,8 @@
> > persistent properties must have getter methods.
> > property-no-setter: No setter method found for persistent property
> > "{0}", and \
> > bytecode analysis of the getter did not reveal a clear backing
> > field. \
> > - Please create a setter method for this property (it may be
> private).
> > + Please create a setter method for this property which may be a
> > private \
> > + property.
> > property-setter-getter-mismatch: Bytecode analysis of the setter
> > and getter \
> > methods for persistent property "{0}" indicates that the two
> > methods \
> > might be acting on different backing fields. The setter method
> > assigns to \
> >
> >
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
>
>