You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/02 14:47:51 UTC
Re: Review Request 39466: Added http::put request method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39466/
-----------------------------------------------------------
(Updated Jan. 2, 2016, 1:47 p.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Bugs: MESOS-3763
https://issues.apache.org/jira/browse/MESOS-3763
Repository: mesos
Description
-------
Added http::put request method.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236
3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969
3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
Diff: https://reviews.apache.org/r/39466/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 39466: Added http::put request method.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39466/#review112447
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39466]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 2, 2016, 1:47 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39466/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 1:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3763
> https://issues.apache.org/jira/browse/MESOS-3763
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added http::put request method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236
> 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969
> 3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
>
> Diff: https://reviews.apache.org/r/39466/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39466: Added http::put request method.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39466/#review112474
-----------------------------------------------------------
Thanks [~joerg84] for the patch. Can you help me understand why aren't we going forward with the following approach as had been already alluded to by [~bmahler] on the JIRA:
- Expose the `internal::http::request` function in the header and not add an additional method/overload for `put` function at all.
- We might at a latter point of time try to clean the other instances of `post/get` to use the `http::request` method.
To me, we don't seem to be gaining much by adding these additional method/overloads for the `put` method when we eventually would want to move away from them. For one, they are making the eventual cleanup harder. What do you think ?
- Anand Mazumdar
On Jan. 2, 2016, 1:47 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39466/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 1:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3763
> https://issues.apache.org/jira/browse/MESOS-3763
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added http::put request method.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp f0666f0fa48c4f3a98332d12066561a02a715236
> 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969
> 3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
>
> Diff: https://reviews.apache.org/r/39466/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>