[GitHub] [accumulo] dlmarion commented on a diff in pull request #2799: Adding support for setting multiple properties at once atomically

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2799:
URL: https://github.com/apache/accumulo/pull/2799#discussion_r977875465


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -659,6 +680,24 @@ default Iterable<Entry<String,String>> getProperties(String tableName)
   Map<String,String> getConfiguration(String tableName)
       throws AccumuloException, TableNotFoundException;
 
+  /**
+   * Gets per-table properties of a table. This operation is asynchronous and eventually consistent.
+   * It is not guaranteed that all tablets in a table will return the same values. Within a few
+   * seconds without another change, all tablets in a table should be consistent. The clone table
+   * feature can be used if consistency is required. This new method returns a Map instead of an

Review Comment:
   Do we need to say "This new method returns a Map instead of an Iterable."? If we leave this in place (in multiple places), maybe we should add something to say why?



##########
server/base/src/main/java/org/apache/accumulo/server/conf/store/PropStore.java:
##########
@@ -76,6 +76,24 @@ public interface PropStore {
    */
   void putAll(PropStoreKey<?> propStoreKey, Map<String,String> props);
 
+  /**
+   * Replaces all current properties with map provided If a property is not included in the new map,

Review Comment:
   ```suggestion
      * Replaces all current properties with map provided. If a property is not included in the new map,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org