You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/04/17 08:09:10 UTC
svn commit: r1876656 - in
/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel:
font/ graphics/image/ interactive/form/
Author: tilman
Date: Fri Apr 17 08:09:10 2020
New Revision: 1876656
URL: http://svn.apache.org/viewvc?rev=1876656&view=rev
Log:
PDFBOX-4071: Sonar fix, correct assert order
Modified:
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java Fri Apr 17 08:09:10 2020
@@ -175,7 +175,7 @@ public class PDFontTest
doc = PDDocument.load(outputFile);
font = (PDType1Font) doc.getPage(0).getResources().getFont(COSName.getPDFName("F1"));
- Assert.assertEquals(font.getEncoding(), WinAnsiEncoding.INSTANCE);
+ Assert.assertEquals(WinAnsiEncoding.INSTANCE, font.getEncoding());
for (char c : text.toCharArray())
{
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/graphics/image/PNGConverterTest.java Fri Apr 17 08:09:10 2020
@@ -252,7 +252,7 @@ public class PNGConverterTest
assertTrue(PNGConverter.checkChunkSane(null));
chunk.bytes = "IHDRsomedummyvaluesDummyValuesAtEnd".getBytes();
chunk.length = 19;
- assertEquals(chunk.bytes.length, 35);
+ assertEquals(35, chunk.bytes.length);
assertEquals("IHDRsomedummyvalues", new String(chunk.getData()));
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java Fri Apr 17 08:09:10 2020
@@ -73,7 +73,7 @@ public class PDAcroFormTest
// the /Fields entry has been created with the AcroForm
// as this is a required entry
assertNotNull(acroForm.getFields());
- assertEquals(acroForm.getFields().size(),0);
+ assertEquals(0, acroForm.getFields().size());
// there shouldn't be an exception if there is no such field
assertNull(acroForm.getField("foo"));
@@ -84,7 +84,7 @@ public class PDAcroFormTest
// ensure there is always an empty collection returned
assertNotNull(acroForm.getFields());
- assertEquals(acroForm.getFields().size(),0);
+ assertEquals(0, acroForm.getFields().size());
// there shouldn't be an exception if there is no such field
assertNull(acroForm.getField("foo"));
@@ -95,7 +95,7 @@ public class PDAcroFormTest
{
assertTrue(acroForm.getDefaultAppearance().isEmpty());
acroForm.setDefaultAppearance("/Helv 0 Tf 0 g");
- assertEquals(acroForm.getDefaultAppearance(),"/Helv 0 Tf 0 g");
+ assertEquals("/Helv 0 Tf 0 g", acroForm.getDefaultAppearance());
}
@Test
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java Fri Apr 17 08:09:10 2020
@@ -58,7 +58,7 @@ public class PDChoiceTest
PDChoice choiceField = new PDListBox(acroForm);
assertEquals(choiceField.getFieldType(), choiceField.getCOSObject().getNameAsString(COSName.FT));
- assertEquals(choiceField.getFieldType(), "Ch");
+ assertEquals("Ch", choiceField.getFieldType());
assertFalse(choiceField.isCombo());
}
@@ -68,7 +68,7 @@ public class PDChoiceTest
PDChoice choiceField = new PDComboBox(acroForm);
assertEquals(choiceField.getFieldType(), choiceField.getCOSObject().getNameAsString(COSName.FT));
- assertEquals(choiceField.getFieldType(), "Ch");
+ assertEquals("Ch", choiceField.getFieldType());
assertTrue(choiceField.isCombo());
}
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java Fri Apr 17 08:09:10 2020
@@ -53,7 +53,7 @@ public class PDSignatureFieldTest
sigField.setPartialName("SignatureField");
assertEquals(sigField.getFieldType(), sigField.getCOSObject().getNameAsString(COSName.FT));
- assertEquals(sigField.getFieldType(), "Sig");
+ assertEquals("Sig", sigField.getFieldType());
assertEquals(COSName.ANNOT, sigField.getCOSObject().getItem(COSName.TYPE));
assertEquals(PDAnnotationWidget.SUB_TYPE, sigField.getCOSObject().getNameAsString(COSName.SUBTYPE));
Modified: pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java?rev=1876656&r1=1876655&r2=1876656&view=diff
==============================================================================
--- pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java (original)
+++ pdfbox/branches/issue45/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java Fri Apr 17 08:09:10 2020
@@ -48,7 +48,7 @@ public class PDTextFieldTest
PDField textField = new PDTextField(acroForm);
assertEquals(textField.getFieldType(), textField.getCOSObject().getNameAsString(COSName.FT));
- assertEquals(textField.getFieldType(), "Tx");
+ assertEquals("Tx", textField.getFieldType());
}
@Test