[GitHub] [iceberg] jackye1995 commented on a change in pull request #2921: Add an argument to parallelize Expire snapshot procedure

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2921:
URL: https://github.com/apache/iceberg/pull/2921#discussion_r707785204



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -90,7 +96,14 @@ public StructType outputType() {
       if (retainLastNum != null) {
         action.retainLast(retainLastNum);
       }
-
+      if (numThreads != null && numThreads > 0) {

Review comment:
       I think keeping the null value is the correct behavior, because if `executeDeleteWith` is not set, then the execution will happen in the current thread. Otherwise this will create a new thread pool of size 1 and use that for execution.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org