You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/04 10:02:12 UTC
[GitHub] [flink] zentol opened a new pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
zentol opened a new pull request #15827:
URL: https://github.com/apache/flink/pull/15827
Removes auto-generated maven metadata from all jars as this may accidentally bundle poms under incompatible licenses, and adds another exclusions for jboss schema files contained in flink-python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054af9b357b26f41fd879384b1a0fe3ddddb35cc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627481488
##########
File path: pom.xml
##########
@@ -1740,8 +1742,21 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
- <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
- <exclude>META-INF/maven/**</exclude>
+ <!-- META-INF/maven can contain 2 things:
+ - For archetypes, it contains an archetype-metadata.xml.
+ - For other jars, it contains the pom for all dependencies under the respective <groupId>/<artifactId>/ directory.
+
+ We want to exclude the poms because they may be under an incompatible license,
+ however the archetype metadata is required and we need to keep that around.
+
+ This pattern excludes directories under META-INF/maven.
+ ('?*/**' does not work because '**' also matches zero directories;
+ everything that matches '?*' also matches '?*/**')
+
+ The initial '**' allows the pattern to also work for multi-release jars that may contain such entries under
+ 'META-INF/versions/11/META-INF/maven/'.
+ -->
+ <exclude>**/META-INF/maven/?*/?*/**</exclude>
Review comment:
Ah ok. Then let's keep the current solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831829389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 054af9b357b26f41fd879384b1a0fe3ddddb35cc (Tue May 04 10:08:55 UTC 2021)
**Warnings:**
* **11 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627304960
##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -247,6 +247,10 @@ under the License.
<goal>test-jar-no-fork</goal>
</goals>
<configuration>
+ <archive>
+ <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
+ <addMavenDescriptor>false</addMavenDescriptor>
Review comment:
ideally we move this into the pluginManagement section in the root pom, but I already spent too much time on this ticket (and actually pin the plugin version...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r625691675
##########
File path: pom.xml
##########
@@ -1748,6 +1748,7 @@ under the License.
<exclude>log4j2.properties</exclude>
<exclude>log4j-test.properties</exclude>
<exclude>log4j2-test.properties</exclude>
+ <exclude>META-INF/maven/**</exclude>
Review comment:
TODO: double-check that this also works properly for multi-release jars (e.g., flink-dist)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
}, {
"hash" : "6250916c9e993933d67b1caa6165adae338e9f67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6250916c9e993933d67b1caa6165adae338e9f67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a82a2746db1f7e073849b4885dcff2c98d13d4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571)
* 6250916c9e993933d67b1caa6165adae338e9f67 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627302956
##########
File path: flink-dist/pom.xml
##########
@@ -679,7 +679,7 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration combine.self="override">
Review comment:
this removal is safe because it is a distinct execution, and hence never had any effect.
##########
File path: flink-dist/pom.xml
##########
@@ -734,22 +723,11 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration combine.self="override">
Review comment:
this removal is safe because it is a distinct execution, and hence never had any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627304356
##########
File path: flink-kubernetes/pom.xml
##########
@@ -129,7 +129,7 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration combine.children="append">
Review comment:
afaik this doesn't make sense and just results in any parent configurations being ignored. Similar to cassandra it is unnecessary because we aren't doing anything special, and we get rid of an odd special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-832728951
Well this was quite an ordeal.
The quickstart test failure was related; archetype jars contain an archetype-metadata.xml file under `META-INF/maven`, that was now accidentally removed. The filter pattern was adjusted to ignore this files.
We then had various files still containing poms under `META-INF/maven`.
Once cause was jars being built with the `maven-(jar|assembly|source)-plugin`, which needed to be configured separately to not add these files.
The second cause was various modules using ever so slightly shade-plugin setups; some were flat-out overriding the configuration of the parent so they didn't inherit things (like cassandra), others like flink-dist have special shade-plugin executions for _reasons_. This was resolved by moving the filters (and common transformers, while I was at it) into the general configuration of the shade-plugin (i.e., independent of any execution) and making small adjustments here and there as to how configurations are inherited/merged.
Finally, the java11 exclusive dependencies still contained poms, because the pattern assumed this directory to always be present under `META-INF/maven`, but for multi-release jars it can be present under `META-INF/versions/...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054af9b357b26f41fd879384b1a0fe3ddddb35cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540)
* 7a82a2746db1f7e073849b4885dcff2c98d13d4b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a82a2746db1f7e073849b4885dcff2c98d13d4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054af9b357b26f41fd879384b1a0fe3ddddb35cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540)
* 7a82a2746db1f7e073849b4885dcff2c98d13d4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-832728951
Well this was quite an ordeal.
The quickstart test failure was related; archetype jars contain an archetype-metadata.xml file under `META-INF/maven`, that was now accidentally removed. The filter pattern was adjusted to ignore this files.
We then had various files still containing poms under `META-INF/maven`:
Once cause was jars being built with the `maven-(jar|assembly|source)-plugin`, which needed to be configured separately to not add these files.
The second cause was various modules using ever so slightly shade-plugin setups; some were flat-out overriding the configuration of the parent so they didn't inherit things (like cassandra), others like flink-dist have special shade-plugin executions for _reasons_. This was resolved by moving the filters (and common transformers, while I was at it) into the general configuration of the shade-plugin (i.e., independent of any execution) and making small adjustments here and there as to how configurations are inherited/merged.
Finally, the java11 exclusive dependencies still contained poms, because the pattern assumed this directory to always be present under `META-INF/maven`, but for multi-release jars it can be present under `META-INF/versions/...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054af9b357b26f41fd879384b1a0fe3ddddb35cc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627303391
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -63,8 +63,9 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
- <configuration combine.self="override">
Review comment:
this removal is safe because it the override was plain unnecessary, and we get rid of an odd special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
}, {
"hash" : "6250916c9e993933d67b1caa6165adae338e9f67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17631",
"triggerID" : "6250916c9e993933d67b1caa6165adae338e9f67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7a82a2746db1f7e073849b4885dcff2c98d13d4b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571)
* 6250916c9e993933d67b1caa6165adae338e9f67 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627272537
##########
File path: pom.xml
##########
@@ -1740,8 +1742,21 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
- <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
- <exclude>META-INF/maven/**</exclude>
+ <!-- META-INF/maven can contain 2 things:
+ - For archetypes, it contains an archetype-metadata.xml.
+ - For other jars, it contains the pom for all dependencies under the respective <groupId>/<artifactId>/ directory.
+
+ We want to exclude the poms because they may be under an incompatible license,
+ however the archetype metadata is required and we need to keep that around.
+
+ This pattern excludes directories under META-INF/maven.
+ ('?*/**' does not work because '**' also matches zero directories;
+ everything that matches '?*' also matches '?*/**')
+
+ The initial '**' allows the pattern to also work for multi-release jars that may contain such entries under
+ 'META-INF/versions/11/META-INF/maven/'.
+ -->
+ <exclude>**/META-INF/maven/?*/?*/**</exclude>
Review comment:
Would it work to explicitly add the `archetype-metadata.xml` in the quickstart as an inclusion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627305243
##########
File path: flink-dist/pom.xml
##########
@@ -675,6 +675,7 @@ under the License.
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
+ <id>shade-dist</id>
Review comment:
This is essentially just a safeguard against accidentally inheriting something from somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 054af9b357b26f41fd879384b1a0fe3ddddb35cc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831839655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17540",
"triggerID" : "054af9b357b26f41fd879384b1a0fe3ddddb35cc",
"triggerType" : "PUSH"
}, {
"hash" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17571",
"triggerID" : "7a82a2746db1f7e073849b4885dcff2c98d13d4b",
"triggerType" : "PUSH"
}, {
"hash" : "6250916c9e993933d67b1caa6165adae338e9f67",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17631",
"triggerID" : "6250916c9e993933d67b1caa6165adae338e9f67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6250916c9e993933d67b1caa6165adae338e9f67 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=17631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15827:
URL: https://github.com/apache/flink/pull/15827#issuecomment-831829389
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2632d0b01743c70bae508a635d94faab83d23052 (Sat Aug 28 11:18:00 UTC 2021)
**Warnings:**
* **15 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #15827:
URL: https://github.com/apache/flink/pull/15827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #15827: [FLINK-22555][build][python] Exclude leftover jboss files
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #15827:
URL: https://github.com/apache/flink/pull/15827#discussion_r627324267
##########
File path: pom.xml
##########
@@ -1740,8 +1742,21 @@ under the License.
<exclude>META-INF/*.SF</exclude>
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
- <!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
- <exclude>META-INF/maven/**</exclude>
+ <!-- META-INF/maven can contain 2 things:
+ - For archetypes, it contains an archetype-metadata.xml.
+ - For other jars, it contains the pom for all dependencies under the respective <groupId>/<artifactId>/ directory.
+
+ We want to exclude the poms because they may be under an incompatible license,
+ however the archetype metadata is required and we need to keep that around.
+
+ This pattern excludes directories under META-INF/maven.
+ ('?*/**' does not work because '**' also matches zero directories;
+ everything that matches '?*' also matches '?*/**')
+
+ The initial '**' allows the pattern to also work for multi-release jars that may contain such entries under
+ 'META-INF/versions/11/META-INF/maven/'.
+ -->
+ <exclude>**/META-INF/maven/?*/?*/**</exclude>
Review comment:
I had the same idea, but don't think it would work because exclusions are used to narrow down inclusions.
The default inclusion is `*`, matching all files and we exclude some of those..
If set an inclusion for `archetype-metadata.xml`, then all other files are implicitly excluded. We'd need include for everything we truly want in the jar, but that seems like more overhead than the current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org