You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2011/06/25 02:14:47 UTC
[jira] [Created] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Remove Lucene core's FunctionQuery impls
----------------------------------------
Key: LUCENE-3241
URL: https://issues.apache.org/jira/browse/LUCENE-3241
Project: Lucene - Java
Issue Type: Sub-task
Reporter: Chris Male
As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-3241:
-------------------------------
Attachment: LUCENE-3241.patch
New patch which incorporates Robert's suggestions.
I have salvaged some of the tests, but theres definitely a big TODO in regards to the test coverage.
Command coming up.
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch, LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057694#comment-13057694 ]
Chris Male commented on LUCENE-3241:
------------------------------------
Command for patch:
{code}
svn move lucene/src/java/org/apache/lucene/search/function/NumericIndexDocValueSource.java modules/queries/src/java/org/apache/lucene/queries/function/valuesource/
svn move lucene/src/test/org/apache/lucene/search/function/TestFieldScoreQuery.java modules/queries/src/test/org/apache/lucene/queries/function/
svn move lucene/src/test/org/apache/lucene/search/function/TestOrdValues.java modules/queries/src/test/org/apache/lucene/queries/function/
svn --force delete lucene/src/java/org/apache/lucene/search/function
svn --force delete lucene/src/test/org/apache/lucene/search/function
{code}
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch, LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male reassigned LUCENE-3241:
----------------------------------
Assignee: Chris Male
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved LUCENE-3241.
--------------------------------
Resolution: Fixed
Committed revision 1141747.
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch, LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057635#comment-13057635 ]
Chris Male commented on LUCENE-3241:
------------------------------------
I will re-evaluate the tests and port what I can.
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057624#comment-13057624 ]
Robert Muir commented on LUCENE-3241:
-------------------------------------
+1 to nuke and remove the duplication, and add stuff to migrate.txt (like the analyzers) saying such and such has moved here.
I'm confused about the tests... I see more tests in lucene-core under the function package than in the queries module? but i didnt look hard... just want to make sure we don't lose anything here.
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057620#comment-13057620 ]
Chris Male commented on LUCENE-3241:
------------------------------------
Command for patch:
{code}
svn move lucene/src/java/org/apache/lucene/search/function/NumericIndexDocValueSource.java modules/queries/src/java/org/apache/lucene/queries/function/valuesource/
{code}
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3241) Remove Lucene core's FunctionQuery
impls
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated LUCENE-3241:
-------------------------------
Attachment: LUCENE-3241.patch
Patch that deprecates the contents of org.apache.lucene.search.function.
I've gone down this road, instead of straight out nuking, since they're in core. If people don't feel this necessary, I'll happily remove them.
The tests for the package do not add anything therefore I haven't moved them.
Ports NumericIndexDocValueSource to Queries module.
> Remove Lucene core's FunctionQuery impls
> ----------------------------------------
>
> Key: LUCENE-3241
> URL: https://issues.apache.org/jira/browse/LUCENE-3241
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: core/search
> Reporter: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-3241.patch
>
>
> As part of the consolidation of FunctionQuerys, we want to remove Lucene core's impls. Included in this work, we will make sure that all the functionality provided by the core impls is also provided by the new module. Any tests will be ported across too, to increase the test coverage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org