You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/07/06 21:48:01 UTC

[GitHub] incubator-trafodion pull request: Fixes for 1438896 and 1465356

GitHub user robertamarton opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/19

    Fixes for 1438896 and 1465356

    1438896: Internal error during create or replace view
    
    The objectUID check when getting privilege information was not correct.
    
    1465356: Revoke privilege from role returns dependent object error
    
    There is a check in mainline revoke code to determine if the object type is a
    view and if the SELECT privilege is no longer applicable. If so, then the
    dependent error is returned. However, this code is incorrect and actually the
    correct code exists in the gatherViewPrivileges method. The view check has been
    removed.
    
    Change-Id: Ia1a00f18bad301dd1439c2ceb079d69808de7bdd

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion wrk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 9c544706429a2dc42277376186e41b28a4ade0f6
Author: Roberta Marton <ro...@hp.com>
Date:   2015-07-01T17:08:11Z

    Fixes for 1438896 and 1465356
    
    1438896: Internal error during create or replace view
    
    The objectUID check when getting privilege information was not correct.
    
    1465356: Revoke privilege from role returns dependent object error
    
    There is a check in mainline revoke code to determine if the object type is a
    view and if the SELECT privilege is no longer applicable. If so, then the
    dependent error is returned. However, this code is incorrect and actually the
    correct code exists in the gatherViewPrivileges method. The view check has been
    removed.
    
    Change-Id: Ia1a00f18bad301dd1439c2ceb079d69808de7bdd

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Fixes for 1438896 and 1465356

Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/19#discussion_r33999953
  
    --- Diff: sql/sqlcomp/PrivMgrPrivileges.cpp ---
    @@ -431,6 +431,22 @@ PrivMgrPrivileges::PrivMgrPrivileges (
     }
     
     // ----------------------------------------------------------------------------
    +// Construct a PrivMgrPrivileges object for on objectUID
    --- End diff --
    
    Looks good - Comment could be updated "for an objectUID" 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: Fixes for 1438896 and 1465356

Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---