You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Michael Armbrust (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 08:28:10 UTC

[jira] [Created] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

JNI bindings shouldn't segfault when passed invalid parameters
--------------------------------------------------------------

                 Key: MESOS-39
                 URL: https://issues.apache.org/jira/browse/MESOS-39
             Project: Mesos
          Issue Type: Bug
          Components: java-api
            Reporter: Michael Armbrust


Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161189#comment-13161189 ] 

Rohit Turumella commented on MESOS-39:
--------------------------------------

It looks like there is a org_apache_mesos_MesosSchedulerDriver.cpp file. What exactly is the relationship between this and the MesosSchedulerDriver class in the java package?

-Rohit
                
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211505#comment-13211505 ] 

Rohit Turumella commented on MESOS-39:
--------------------------------------

I'm trying to run a few tests to make sure that an IllegalArgException is thrown however when i try to run the tests, i get errors relating to the fact that the java files are not compiled. I know I can just compile all the files but I do know that the class files shouldn't be committed. Is there an already existing MakeFile/script that already does the compilation for the java files. It looks like there are a number of dependencies between the java and cpp files that prevent me from even being able to do the compilation from the javac *.java route.

This is one of the errors that I am getting:
MesosSchedulerDriver.java:118: cannot find symbol
symbol  : variable Filters
location: class org.apache.mesos.MesosSchedulerDriver
    return launchTasks(offerId, tasks, Filters.newBuilder().build());

Has anyone run into this issue before?


                
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211505#comment-13211505 ] 

Rohit Turumella edited comment on MESOS-39 at 2/19/12 7:39 PM:
---------------------------------------------------------------

I'm trying to run a few tests to make sure that an IllegalArgException is thrown however when i try to run the tests, i get errors relating to the fact that the java files are not compiled. I know I can just compile all the files but I do know that the class files shouldn't be committed. Is there an already existing MakeFile/script that already does the compilation for the java files. It looks like there are a number of dependencies between the java and cpp files that prevent me from even being able to do the compilation from the javac *.java route.

This is one of the errors that I am getting:
MesosSchedulerDriver.java:118: cannot find symbol
symbol  : variable Filters
location: class org.apache.mesos.MesosSchedulerDriver
    return launchTasks(offerId, tasks, Filters.newBuilder().build());

Has anyone run into this issue before?

Note: I haven't changed anything in the java files (only the org_apache_mesos_MesosSchedulerDriver.cpp file).

                
      was (Author: rturumella):
    I'm trying to run a few tests to make sure that an IllegalArgException is thrown however when i try to run the tests, i get errors relating to the fact that the java files are not compiled. I know I can just compile all the files but I do know that the class files shouldn't be committed. Is there an already existing MakeFile/script that already does the compilation for the java files. It looks like there are a number of dependencies between the java and cpp files that prevent me from even being able to do the compilation from the javac *.java route.

This is one of the errors that I am getting:
MesosSchedulerDriver.java:118: cannot find symbol
symbol  : variable Filters
location: class org.apache.mesos.MesosSchedulerDriver
    return launchTasks(offerId, tasks, Filters.newBuilder().build());

Has anyone run into this issue before?

Note I haven't changed anything in the java files (only the org_apache_mesos_MesosSchedulerDriver.cpp file).

                  
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212359#comment-13212359 ] 

Rohit Turumella commented on MESOS-39:
--------------------------------------

Andy -- I've sucessfully built Mesos (downloaded the version using autotools). The issue I am having is with regards to running a custom unit test that I've created to test this JIRA (I initialize a Mesos scheduler driver with invalid parameters and check to see if an exception is thrown). 

When I tried to compile this unit test, I get  errors relating to the fact that the java files are not compiled (schedulerdriver, executor,etc.).
                
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211505#comment-13211505 ] 

Rohit Turumella edited comment on MESOS-39 at 2/19/12 7:38 PM:
---------------------------------------------------------------

I'm trying to run a few tests to make sure that an IllegalArgException is thrown however when i try to run the tests, i get errors relating to the fact that the java files are not compiled. I know I can just compile all the files but I do know that the class files shouldn't be committed. Is there an already existing MakeFile/script that already does the compilation for the java files. It looks like there are a number of dependencies between the java and cpp files that prevent me from even being able to do the compilation from the javac *.java route.

This is one of the errors that I am getting:
MesosSchedulerDriver.java:118: cannot find symbol
symbol  : variable Filters
location: class org.apache.mesos.MesosSchedulerDriver
    return launchTasks(offerId, tasks, Filters.newBuilder().build());

Has anyone run into this issue before?

Note I haven't changed anything in the java files (only the org_apache_mesos_MesosSchedulerDriver.cpp file).

                
      was (Author: rturumella):
    I'm trying to run a few tests to make sure that an IllegalArgException is thrown however when i try to run the tests, i get errors relating to the fact that the java files are not compiled. I know I can just compile all the files but I do know that the class files shouldn't be committed. Is there an already existing MakeFile/script that already does the compilation for the java files. It looks like there are a number of dependencies between the java and cpp files that prevent me from even being able to do the compilation from the javac *.java route.

This is one of the errors that I am getting:
MesosSchedulerDriver.java:118: cannot find symbol
symbol  : variable Filters
location: class org.apache.mesos.MesosSchedulerDriver
    return launchTasks(offerId, tasks, Filters.newBuilder().build());

Has anyone run into this issue before?


                  
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161190#comment-13161190 ] 

Rohit Turumella commented on MESOS-39:
--------------------------------------

It looks like there is a org_apache_mesos_MesosSchedulerDriver.cpp file. What exactly is the relationship between this and the MesosSchedulerDriver class in the java package?

-Rohit
                
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Andy Konwinski (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212356#comment-13212356 ] 

Andy Konwinski commented on MESOS-39:
-------------------------------------

So, is the problem that you can't get the example and tests to run without making any changes to the source (i.e. on a clean SVN checkout), or is it that you can't get them to build once you've made changes to org_apache_mesos_MesosSchedulerDriver.cpp?

Have you followed the new instructions on the wiki for building and running the tests (i.e. at https://github.com/mesos/mesos/wiki under "Running Example Frameworks and Testing the Build")

Hopefully you just haven't seen that wiki page since we updated it a couple of weeks ago (this all changed recently with the big move to autotools build system) and this will solve your problem (that page states the following in that section: "Currently, in order to run the example frameworks (in src/examples), you must first build the test suite, as instructed below.").
                
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MESOS-39) JNI bindings shouldn't segfault when passed invalid parameters

Posted by "Rohit Turumella (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MESOS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rohit Turumella reassigned MESOS-39:
------------------------------------

    Assignee: Rohit Turumella
    
> JNI bindings shouldn't segfault when passed invalid parameters
> --------------------------------------------------------------
>
>                 Key: MESOS-39
>                 URL: https://issues.apache.org/jira/browse/MESOS-39
>             Project: Mesos
>          Issue Type: Bug
>          Components: java-api
>            Reporter: Michael Armbrust
>            Assignee: Rohit Turumella
>
> Right now if you pass null values to the SchedulerDriver constructor it causes the JVM to segfault.  It would be much nicer if you threw an IllegalArgumentException with a helpful message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira