You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/09 13:10:33 UTC
[PR] test(alert): pin the native metric catalog endpoint [rocketmq-dashboard]
zjncs opened a new pull request, #5864:
URL: https://github.com/apache/rocketmq-dashboard/pull/5864
### What
`NativeAlertMetricCatalogController` exposes the collectible native metrics per instance and domain (`/api/native-alert-metrics`) — the source the alert-rule editor lists semantic metrics from. It had no test. This adds 2 tests.
### What is pinned
- it **delegates with the instance and domain verbatim** and wraps the answer in a success `Result`;
- **an instance without native metrics yields an empty catalog**, not an error.
### Verification
- New tests on unmodified code: **2/2 green**, checkstyle clean.
- Discriminating mutation: the success wrapper replaced with an error (red).
- Restored: 2/2 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(alert): pin the native metric catalog endpoint [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #5864: test(alert): pin the native metric catalog endpoint
URL: https://github.com/apache/rocketmq-dashboard/pull/5864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(alert): pin the native metric catalog endpoint [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #5864:
URL: https://github.com/apache/rocketmq-dashboard/pull/5864#issuecomment-6729161222
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org