[jira] [Commented] (KAFKA-17207) ConnectWorkerIntegrationTest.testRequestTimeouts times out in stop(), leaking clients

["Francis Godinho (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013376#comment-18013376 ] 

Francis Godinho commented on KAFKA-17207:
-----------------------------------------

Hi [~gharris1727], i made a PR for this. Can you please help take a look when you get a chance? Thanks! [https://github.com/apache/kafka/pull/20307]  

> ConnectWorkerIntegrationTest.testRequestTimeouts times out in stop(), leaking clients
> -------------------------------------------------------------------------------------
>
>                 Key: KAFKA-17207
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17207
>             Project: Kafka
>          Issue Type: Test
>          Components: connect
>    Affects Versions: 3.9.0
>            Reporter: Greg Harris
>            Assignee: Francis Godinho
>            Priority: Minor
>              Labels: newbie
>
> The testRequestTimeouts deletes the internal config topic, putting the connect workers into a bad state. When the test goes to clean up, it calls DistributedHerder#stop, which waits for the herder executor to stop. This times out, because the herder executor is blocked closing the KafkaConfigBackingStore's producer. This log message gets printed:
> {noformat}
> [2024-07-26 11:52:50,817] ERROR Executor java.util.concurrent.ThreadPoolExecutor@7ae97a58[Shutting down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 0] did not terminate in time (org.apache.kafka.common.utils.ThreadUtils:83){noformat}
> This effectively leaks the Kafka clients for the workers' internal topics, and the herder executor thread. Instead, either the producer should not block indefinitely on a missing topic, or the cluster state should be healed enough for the producer to shutdown cleanly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)