You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/12/19 23:22:54 UTC
Review Request 54878: Add some simple ldd() tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54878/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Bugs: MESOS-6588
https://issues.apache.org/jira/browse/MESOS-6588
Repository: mesos
Description
-------
Add some simple ldd() tests.
Diffs
-----
src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b
src/tests/CMakeLists.txt 731d58c5e45e1e5f2f47155ebe556a97fb443044
src/tests/ldd_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54878/diff/
Testing
-------
make check (Fedora 25).
Thanks,
James Peach
Re: Review Request 54878: Add some simple ldd() tests.
Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54878/#review163643
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/ldd_tests.cpp (line 48)
<https://reviews.apache.org/r/54878/#comment235123>
Not that there's anything wrong with it but we rarely do this, especially when this output provides no additional runtime info on why this expectation failed. Just using a comment is more typical. Also this raises the question of "why only do it for this check"?
src/tests/ldd_tests.cpp (line 58)
<https://reviews.apache.org/r/54878/#comment235125>
Nit: `strings::startsWith` it a bit cleaner and I don't need to count the number of chars? :)
src/tests/ldd_tests.cpp (line 62)
<https://reviews.apache.org/r/54878/#comment235127>
Ditto about `<<`.
- Jiang Yan Xu
On Dec. 19, 2016, 3:22 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54878/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2016, 3:22 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6588
> https://issues.apache.org/jira/browse/MESOS-6588
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some simple ldd() tests.
>
>
> Diffs
> -----
>
> src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b
> src/tests/CMakeLists.txt 731d58c5e45e1e5f2f47155ebe556a97fb443044
> src/tests/ldd_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54878/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 54878: Add some simple ldd() tests.
Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54878/#review164170
-----------------------------------------------------------
Ship it!
src/tests/ldd_tests.cpp (line 79)
<https://reviews.apache.org/r/54878/#comment235760>
Two space indentation. No worries I fix it.
- Jiang Yan Xu
On Feb. 1, 2017, 3:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54878/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 3:52 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6588
> https://issues.apache.org/jira/browse/MESOS-6588
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some simple ldd() tests.
>
>
> Diffs
> -----
>
> src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
> src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c
> src/tests/ldd_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54878/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 54878: Add some simple ldd() tests.
Posted by Jiang Yan Xu <xu...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54878/#review163906
-----------------------------------------------------------
Ship it!
src/tests/ldd_tests.cpp (line 47)
<https://reviews.apache.org/r/54878/#comment235419>
No big deal, but we could just do `dependencies->contains()` which is shorter.
- Jiang Yan Xu
On Feb. 1, 2017, 3:52 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54878/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 3:52 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Bugs: MESOS-6588
> https://issues.apache.org/jira/browse/MESOS-6588
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add some simple ldd() tests.
>
>
> Diffs
> -----
>
> src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
> src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c
> src/tests/ldd_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/54878/diff/
>
>
> Testing
> -------
>
> make check (Fedora 25).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 54878: Add some simple ldd() tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54878/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 11:52 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebase and address review feedback.
Bugs: MESOS-6588
https://issues.apache.org/jira/browse/MESOS-6588
Repository: mesos
Description
-------
Add some simple ldd() tests.
Diffs (updated)
-----
src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430
src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c
src/tests/ldd_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/54878/diff/
Testing
-------
make check (Fedora 25).
Thanks,
James Peach