You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/09/01 02:10:16 UTC

[kudu-CR] [threadpool] Fix an extreme coredump bug when shutdown thread pool with SchedulerThread

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18867 )

Change subject: [threadpool] Fix an extreme coredump bug when shutdown thread pool with SchedulerThread
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/18867/7//COMMIT_MSG
Commit Message:

PS7: 
Please make the commit description to conform with the guidelines at https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines (which is referenced at https://kudu.apache.org/docs/contributing.html#_submitting_patches)


http://gerrit.cloudera.org:8080/#/c/18867/7//COMMIT_MSG@7
PS7, Line 7: extreme
What's extreme here?


http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc
File src/kudu/util/threadpool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@186
PS7, Line 186: ForExtreme
What's 'extreme'?


http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@187
PS7, Line 187:   VLOG(1) << "hello from task: " << i;
What is this for?


http://gerrit.cloudera.org:8080/#/c/18867/7/src/kudu/util/threadpool-test.cc@202
PS7, Line 202: || status.IsIllegalState()
Why to expect Status::IllegalState() here?  Please add a comment to clarify.



-- 
To view, visit http://gerrit.cloudera.org:8080/18867
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I021422f7e51e1007c5bdbc877ab445f70ba12357
Gerrit-Change-Number: 18867
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 02:10:16 +0000
Gerrit-HasComments: Yes