You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 18:36:48 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #12844: ARROW-15951: [CI][Python] "Test wheel" step successful despite test error

assignUser commented on code in PR #12844:
URL: https://github.com/apache/arrow/pull/12844#discussion_r846386550


##########
ci/scripts/python_wheel_windows_test.bat:
##########
@@ -35,21 +35,21 @@ set ARROW_TEST_DATA=C:\arrow\testing\data
 set PARQUET_TEST_DATA=C:\arrow\submodules\parquet-testing\data
 
 @REM Install testing dependencies
-pip install -r C:\arrow\python\requirements-wheel-test.txt || exit /B
+pip install -r C:\arrow\python\requirements-wheel-test.txt || exit /B 1
 
 @REM Install the built wheels
-python -m pip install --no-index --find-links=C:\arrow\python\dist\ pyarrow || exit /B
+python -m pip install --no-index --find-links=C:\arrow\python\dist\ pyarrow || exit /B 1 
 
 @REM Test that the modules are importable
-python -c "import pyarrow" || exit /B
-python -c "import pyarrow._hdfs" || exit /B
-python -c "import pyarrow._s3fs" || exit /B
-python -c "import pyarrow.csv" || exit /B
-python -c "import pyarrow.dataset" || exit /B
-python -c "import pyarrow.flight" || exit /B
-python -c "import pyarrow.fs" || exit /B
-python -c "import pyarrow.json" || exit /B
-python -c "import pyarrow.parquet" || exit /B
+python -c "import pyarrow" || exit /B 1
+python -c "import pyarrow._hdfs" || exit /B 1 
+python -c "import pyarrow._s3fs" || exit /B 1
+python -c "import pyarrow.csv" || exit /B 1
+python -c "import pyarrow.dataset" || exit /B 1
+python -c "import pyarrow.flight" || exit /B 1
+python -c "import pyarrow.fs" || exit /B 1
+python -c "import pyarrow.json" || exit /B 1
+python -c "import pyarrow.parquet" || exit /B 1
 
 @REM Execute unittest
-pytest -r s --pyargs pyarrow || exit /B
+pytest -r s --pyargs pyarrow || exit /B 1

Review Comment:
   This would probably also have worked:
   ```suggestion
   pytest -r s --pyargs pyarrow
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org