You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by hy...@apache.org on 2020/03/26 03:09:22 UTC
[dubbo] branch master updated: some code optimization for
ClassGenerator.java and DubboMonitor.java (#5746)
This is an automated email from the ASF dual-hosted git repository.
hyunkun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 7dbe632 some code optimization for ClassGenerator.java and DubboMonitor.java (#5746)
7dbe632 is described below
commit 7dbe632025ef4c991a635314fbb2bc6e344a3574
Author: ZZMarquis <zh...@163.com>
AuthorDate: Thu Mar 26 11:08:39 2020 +0800
some code optimization for ClassGenerator.java and DubboMonitor.java (#5746)
---
.../java/org/apache/dubbo/common/bytecode/ClassGenerator.java | 6 ++----
.../main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java | 8 ++------
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java b/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java
index fdcabb8..c4ecea6 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java
@@ -101,11 +101,9 @@ public final class ClassGenerator {
StringBuilder modifier = new StringBuilder();
if (Modifier.isPublic(mod)) {
modifier.append("public");
- }
- if (Modifier.isProtected(mod)) {
+ } else if (Modifier.isProtected(mod)) {
modifier.append("protected");
- }
- if (Modifier.isPrivate(mod)) {
+ } else if (Modifier.isPrivate(mod)) {
modifier.append("private");
}
diff --git a/dubbo-monitor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java b/dubbo-monitor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
index 9eeb677..a2021b3 100644
--- a/dubbo-monitor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
+++ b/dubbo-monitor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
@@ -63,17 +63,13 @@ public class DubboMonitor implements Monitor {
private final MonitorService monitorService;
- /**
- * The time interval for timer <b>scheduledExecutorService</b> to send data
- */
- private final long monitorInterval;
-
private final ConcurrentMap<Statistics, AtomicReference<long[]>> statisticsMap = new ConcurrentHashMap<Statistics, AtomicReference<long[]>>();
public DubboMonitor(Invoker<MonitorService> monitorInvoker, MonitorService monitorService) {
this.monitorInvoker = monitorInvoker;
this.monitorService = monitorService;
- this.monitorInterval = monitorInvoker.getUrl().getPositiveParameter("interval", 60000);
+ // The time interval for timer <b>scheduledExecutorService</b> to send data
+ final long monitorInterval = monitorInvoker.getUrl().getPositiveParameter("interval", 60000);
// collect timer for collecting statistics data
sendFuture = scheduledExecutorService.scheduleWithFixedDelay(() -> {
try {