[jira] [Commented] (HIVE-21737) Upgrade Avro to version 1.9.1

["Nandor Kollar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921487#comment-16921487 ] 

Nandor Kollar commented on HIVE-21737:
--------------------------------------

[~Fokko] changes on {{RelTreeSignature.java}} look unrelated, would you mind reverting those?

In addition, I'm afraid that [this|https://github.com/apache/hive/blob/master/serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java#L238] part of TypeInfoToSchema no longer sets default to null as it used to do: this call landed [here|https://github.com/apache/avro/blob/branch-1.8/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L394] before, but now [this|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L557] constructor is getting called, which - if I'm not mistaken - will end with a {{org.apache.avro.AvroRuntimeException: Unknown datum class: class com.fasterxml.jackson.databind.node.NullNode}}. Is my assumption correct? Unfortunately I'm not too familiar with Hive, so I don't know which test case would fail.
I think we should simply get rid of Jackson classes here, and just pass null in the Schema.Field constructor.

> Upgrade Avro to version 1.9.1
> -----------------------------
>
>                 Key: HIVE-21737
>                 URL: https://issues.apache.org/jira/browse/HIVE-21737
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: Ismaël Mejía
>            Assignee: Fokko Driesprong
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: 0001-HIVE-21737-Bump-Apache-Avro-to-1.9.1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Avro 1.9.0 was released recently. It brings a lot of fixes including a leaner version of Avro without Jackson in the public API. Worth the update.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)