You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@ectoplasm.org> on 2004/12/15 23:47:49 UTC
[Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Here is a new version of my original patch that includes tests (no doc though)
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: [Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> Stas Bekman wrote:
>
>> Philippe M. Chiasson wrote:
>>
>>> Here is a new version of my original patch that includes tests (no
>>> doc though)
so when committing please add a least a very basic doc in config.pod so we
can point users to it, and I'll extend those later.
>>> + merge_item(PerlPostConfigRequire);
>>
>>
>> I was wondering if it makes sense to merge this one.
>
>
> It's necessary, for the same reason PerlRequire or PerlModule
> has to be merged. Otherwise, the vhost config for PerlPostConfigRequire
> will get lost in the merge. (You'll notice my original patch wasn't merging
> and wasn't working as a side effect)
Yes, of course. For some reason I thought that it'll then run
PerlPostConfigRequire in a vhost, even though it was defined on the top leve.
>> Philippe, mind you not add lines like: /^ $/, I have to cleanup
>> those after every of your commits :( Any chance your editor can be
>> configured not to add those space padding?
>
>
> Yes, sorry 'bout that. I've figured out how to avoid this hapenning with
> my favorite (unnamed) editor ;-).
gozer++
> BTW, I noticed that there are a lot of these kind of /^ $/ in
> src/modules/perl/*.c
guess why :)
> as of today. If you want, I'll go thru them and make a whitespace
> cleanup patch later
> on today.
if you really want to, sure. Otherwise I'm fine with cleaning those up
when seeing them
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
>
>>Here is a new version of my original patch that includes tests (no doc
>>though)
>
>>+ merge_item(PerlPostConfigRequire);
>
> I was wondering if it makes sense to merge this one.
It's necessary, for the same reason PerlRequire or PerlModule
has to be merged. Otherwise, the vhost config for PerlPostConfigRequire
will get lost in the merge. (You'll notice my original patch wasn't merging
and wasn't working as a side effect)
>>+
>
> Philippe, mind you not add lines like: /^ $/, I have to cleanup those
> after every of your commits :( Any chance your editor can be configured
> not to add those space padding?
Yes, sorry 'bout that. I've figured out how to avoid this hapenning with
my favorite (unnamed) editor ;-).
BTW, I noticed that there are a lot of these kind of /^ $/ in src/modules/perl/*.c
as of today. If you want, I'll go thru them and make a whitespace cleanup patch later
on today.
>>Index: t/htdocs/vhost/post_config.pl
>>===================================================================
>>--- t/htdocs/vhost/post_config.pl (revision 0)
>>+++ t/htdocs/vhost/post_config.pl (revision 0)
>>@@ -0,0 +1,9 @@
>>+use warnings;
>>+use strict;
>
>
> should be:
>
> use strict;
> use warnings FATAL => 'all';
Yes
>>Index: t/response/TestVhost/config.pm
>>===================================================================
>>--- t/response/TestVhost/config.pm (revision 112024)
>>+++ t/response/TestVhost/config.pm (working copy)
>>@@ -17,19 +17,25 @@
>>
>> use Apache::Const -compile => 'OK';
>>
>>+our $Restart_Count;
>
> anything wrong with $restart_count? and I'd add a comment:
>
> # initialized in t/htdocs/vhost/post_config.pl
Good thoughs. Patch attached.
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: [Patch mp2] PerlConfigRequire && PerlPostConfigRequire
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> Here is a new version of my original patch that includes tests (no doc
> though)
> + merge_item(PerlPostConfigRequire);
I was wondering if it makes sense to merge this one.
> +
Philippe, mind you not add lines like: /^ $/, I have to cleanup those
after every of your commits :( Any chance your editor can be configured
not to add those space padding?
> Index: t/htdocs/vhost/post_config.pl
> ===================================================================
> --- t/htdocs/vhost/post_config.pl (revision 0)
> +++ t/htdocs/vhost/post_config.pl (revision 0)
> @@ -0,0 +1,9 @@
> +use warnings;
> +use strict;
should be:
use strict;
use warnings FATAL => 'all';
> Index: t/response/TestVhost/config.pm
> ===================================================================
> --- t/response/TestVhost/config.pm (revision 112024)
> +++ t/response/TestVhost/config.pm (working copy)
> @@ -17,19 +17,25 @@
>
> use Apache::Const -compile => 'OK';
>
> +our $Restart_Count;
anything wrong with $restart_count? and I'd add a comment:
# initialized in t/htdocs/vhost/post_config.pl
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org