You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/05 08:55:10 UTC

Review Request 64332: Removed `constexpr`-ness from `cpp17::invoke`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64332/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

`std::invoke` is not marked `constexpr`.


Diffs
-----

  3rdparty/stout/include/stout/cpp17.hpp 3c4cc5345c94270785fa1594d7310af2b4dcf402 


Diff: https://reviews.apache.org/r/64332/diff/1/


Testing
-------


Thanks,

Michael Park

Re: Review Request 64332: Removed `constexpr`-ness from `cpp17::invoke`.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64332/#review192885
-----------------------------------------------------------


Ship it!




- Benjamin Bannier


On Dec. 5, 2017, 9:55 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64332/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 9:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `std::invoke` is not marked `constexpr`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/cpp17.hpp 3c4cc5345c94270785fa1594d7310af2b4dcf402 
> 
> 
> Diff: https://reviews.apache.org/r/64332/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>