Re: [PR] bugfix: finish client channel cleanup when the timer has shut down [incubator-seata]

["slievrly (via GitHub)" <gi...@apache.org>]

slievrly commented on code in PR #8241:
URL: https://github.com/apache/incubator-seata/pull/8241#discussion_r4167389554


##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -664,6 +665,19 @@ private void printMergeMessageLog(MergedWarpMessage mergeMessage) {
     @Sharable
     class ClientHandler extends ChannelDuplexHandler {
 
+        private void executeChannelCleanup(Runnable cleanup) {
+            try {
+                timerExecutor.execute(cleanup);
+            } catch (RejectedExecutionException e) {
+                if (!timerExecutor.isShutdown()) {
+                    throw e;
+                }

Review Comment:
   Added the running-timer rejection regression in e3826bc57. With isShutdown() false and execute() rejecting, both channelInactive and exceptionCaught must propagate the original rejection without running cleanup or forwarding the event. All 6 ClientHandlerShutdownTest cases pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org