You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vogievetsky (via GitHub)" <gi...@apache.org> on 2023/07/17 22:22:04 UTC
[PR] Web console: better schema discovery copy (druid)
vogievetsky opened a new pull request, #14601:
URL: https://github.com/apache/druid/pull/14601
Changing the copy (and default choice) in the dialog that pops up when entering schemaless mode in the data loader.
New dialog:
<img width="426" alt="image" src="https://github.com/apache/druid/assets/177816/c7736d49-d481-4c31-bd56-433de19883ca">
Old dialog (for reference):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: better schema discovery copy (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #14601:
URL: https://github.com/apache/druid/pull/14601#discussion_r1265970162
##########
web-console/src/views/load-data-view/load-data-view.tsx:
##########
@@ -2656,18 +2657,24 @@ export class LoadDataView extends React.PureComponent<LoadDataViewProps, LoadDat
});
}}
>
- Use the new type-aware schema discovery capability. Avoid this if you are appending to a
- datasource created with string-only schema discovery of Druid and want to preserve
- schema compatibility. For more information see the{' '}
- <ExternalLink
- href={`${getLink(
- 'DOCS',
- )}/ingestion/schema-design.html#schema-auto-discovery-for-dimensions`}
- >
- documentation
- </ExternalLink>
- .
- </Switch>
+ <Radio value="type-aware-discovery">
+ Use the new type-aware schema discovery capability. This will discover columns with
+ the best type, columns with multiple values will be ingested as ARRAY types. For more
+ information see the{' '}
+ <ExternalLink
+ href={`${getLink(
+ 'DOCS',
+ )}/ingestion/schema-design.html#schema-auto-discovery-for-dimensions`}
+ >
+ documentation
+ </ExternalLink>
+ .
+ </Radio>
+ <Radio value="string-only-discovery">
+ Use classic string-only schema discovery. This will discover all new columns as
+ strings, columns with multiple values will be ingested as multi-value-strings.
Review Comment:
```suggestion
Use classic string-only schema discovery to discover all new columns as
strings. Columns with multiple values will be ingested as multi-value-strings.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: better schema discovery copy (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #14601:
URL: https://github.com/apache/druid/pull/14601#discussion_r1265969827
##########
web-console/src/views/load-data-view/load-data-view.tsx:
##########
@@ -2656,18 +2657,24 @@ export class LoadDataView extends React.PureComponent<LoadDataViewProps, LoadDat
});
}}
>
- Use the new type-aware schema discovery capability. Avoid this if you are appending to a
- datasource created with string-only schema discovery of Druid and want to preserve
- schema compatibility. For more information see the{' '}
- <ExternalLink
- href={`${getLink(
- 'DOCS',
- )}/ingestion/schema-design.html#schema-auto-discovery-for-dimensions`}
- >
- documentation
- </ExternalLink>
- .
- </Switch>
+ <Radio value="type-aware-discovery">
+ Use the new type-aware schema discovery capability. This will discover columns with
+ the best type, columns with multiple values will be ingested as ARRAY types. For more
+ information see the{' '}
Review Comment:
```suggestion
Use the new type-aware schema discovery capability to discover columns according to data type. Columns with multiple values will be ingested as ARRAY types. For more
information see the{' '}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Web console: better schema discovery copy (druid)
Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky merged PR #14601:
URL: https://github.com/apache/druid/pull/14601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org