You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/10/21 10:14:10 UTC

svn commit: r1894439 - /poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java

Author: fanningpj
Date: Thu Oct 21 10:14:10 2021
New Revision: 1894439

URL: http://svn.apache.org/viewvc?rev=1894439&view=rev
Log:
[bug-65639] add doc about lack of thread saftey

Modified:
    poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java

Modified: poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java?rev=1894439&r1=1894438&r2=1894439&view=diff
==============================================================================
--- poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java (original)
+++ poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/FontEmbeddedData.java Thu Oct 21 10:14:10 2021
@@ -91,12 +91,22 @@ public class FontEmbeddedData extends Re
         out.write(_data);
     }
 
+    /**
+     * Overwrite the font data. Reading values from this FontEmbeddedData instance while calling setFontData
+     * is not thread safe.
+     * @param fontData new font data
+     */
     public void setFontData(byte[] fontData) {
         fontHeader = null;
         _data = fontData.clone();
         LittleEndian.putInt(_header, 4, _data.length);
     }
 
+    /**
+     * Read the font data. Reading values from this FontEmbeddedData instance while calling {@link #setFontData(byte[])}
+     * is not thread safe.
+     * @return font data
+     */
     public FontHeader getFontHeader() {
         if (fontHeader == null) {
             FontHeader h = new FontHeader();



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org