You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry via Review Board <no...@reviews.apache.org> on 2019/07/30 16:51:51 UTC
Review Request 71202: ImportTypeDefProcessor: Now includes processing
AtlasRelationships
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/
-----------------------------------------------------------
Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3220
https://issues.apache.org/jira/browse/ATLAS-3220
Repository: atlas
Description
-------
**Approach**
- Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
Diff: https://reviews.apache.org/r/71202/diff/1/
Testing
-------
**Unit tests**
Existing tests.
**Functional tests**
Export and import tests with steps from bug.
Thanks,
Ashutosh Mestry
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/#review217016
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
Lines 105 (patched)
<https://reviews.apache.org/r/71202/#comment304247>
typedef:entitydef:update => typedef:relationshipdef:update
- Madhan Neethiraj
On July 31, 2019, 8:04 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71202/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 8:04 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3232
> https://issues.apache.org/jira/browse/ATLAS-3232
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
> server-api/src/main/resources/rebel-remote.xml PRE-CREATION
> server-api/src/main/resources/rebel.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71202/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Existing tests.
>
> **Functional tests**
> Export and import tests with steps from bug.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/#review217017
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On July 31, 2019, 1:04 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71202/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 1:04 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3232
> https://issues.apache.org/jira/browse/ATLAS-3232
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
>
>
> Diff: https://reviews.apache.org/r/71202/diff/3/
>
>
> Testing
> -------
>
> **Unit tests**
> Existing tests.
>
> **Functional tests**
> Export and import tests with steps from bug.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Sarath Subramanian <sa...@apache.org>.
> On July 31, 2019, 3:47 p.m., Sarath Subramanian wrote:
> > Ship It!
revert changes to rebel.xml and rebel-remote.xml
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/#review217014
-----------------------------------------------------------
On July 31, 2019, 1:04 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71202/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 1:04 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3232
> https://issues.apache.org/jira/browse/ATLAS-3232
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
> server-api/src/main/resources/rebel-remote.xml PRE-CREATION
> server-api/src/main/resources/rebel.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71202/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Existing tests.
>
> **Functional tests**
> Export and import tests with steps from bug.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/#review217014
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On July 31, 2019, 1:04 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71202/
> -----------------------------------------------------------
>
> (Updated July 31, 2019, 1:04 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3232
> https://issues.apache.org/jira/browse/ATLAS-3232
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
> server-api/src/main/resources/rebel-remote.xml PRE-CREATION
> server-api/src/main/resources/rebel.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71202/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Existing tests.
>
> **Functional tests**
> Export and import tests with steps from bug.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/
-----------------------------------------------------------
(Updated July 31, 2019, 8:04 p.m.)
Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-3232
https://issues.apache.org/jira/browse/ATLAS-3232
Repository: atlas
Description
-------
**Approach**
- Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
server-api/src/main/resources/rebel-remote.xml PRE-CREATION
server-api/src/main/resources/rebel.xml PRE-CREATION
Diff: https://reviews.apache.org/r/71202/diff/2/
Changes: https://reviews.apache.org/r/71202/diff/1-2/
Testing
-------
**Unit tests**
Existing tests.
**Functional tests**
Export and import tests with steps from bug.
Thanks,
Ashutosh Mestry
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/#review216972
-----------------------------------------------------------
Please check if JIRA referenced in this review, ATLAS-3220, is the right one.
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
Lines 74 (patched)
<https://reviews.apache.org/r/71202/#comment304197>
why set end1/end2 to null? For other types, this method sets guid to null.
- Madhan Neethiraj
On July 30, 2019, 4:56 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71202/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 4:56 p.m.)
>
>
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3220
> https://issues.apache.org/jira/browse/ATLAS-3220
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
> - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
>
> **Pre-commit**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
>
>
> Diff: https://reviews.apache.org/r/71202/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Existing tests.
>
> **Functional tests**
> Export and import tests with steps from bug.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 71202: ImportTypeDefProcessor: Now includes
processing AtlasRelationships
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71202/
-----------------------------------------------------------
(Updated July 30, 2019, 4:56 p.m.)
Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include:
- Fixed JIRA ID.
- Added PC build URL.
Bugs: ATLAS-3220
https://issues.apache.org/jira/browse/ATLAS-3220
Repository: atlas
Description (updated)
-------
**Approach**
- Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java c21793733
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java e3d86c862
Diff: https://reviews.apache.org/r/71202/diff/1/
Testing
-------
**Unit tests**
Existing tests.
**Functional tests**
Export and import tests with steps from bug.
Thanks,
Ashutosh Mestry