You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 18:50:57 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #27064: Avoid 500 on dag redirect

dstandish commented on code in PR #27064:
URL: https://github.com/apache/airflow/pull/27064#discussion_r996045701


##########
airflow/www/views.py:
##########
@@ -2454,7 +2454,8 @@ def success(self):
     @action_logging
     def dag(self, dag_id):
         """Redirect to default DAG view."""
-        return redirect(url_for('Airflow.grid', dag_id=dag_id, **request.args))
+        kwargs = {**request.args, "dag_id": dag_id}

Review Comment:
   it seems the effect here is not to prioritize the path, but to always ignore the query param... is that right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org