You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:21:22 UTC
[GitHub] [cloudstack] Yashikaone opened a new pull request, #6662: Feature x
Yashikaone opened a new pull request, #6662:
URL: https://github.com/apache/cloudstack/pull/6662
### Description
This PR...
<!--- Creation of ReadyForShutdown api and PrepareForShutdown api. The ReadyForShutdown api checks across the cloudstack whether it is ready for shutdown or not by monitoring completion of pending asynchronous jobs, and further returns true or false -->
If true safeshutdown will be triggered; if false completion will be awaited and system will be prepared for shutdown with the help of PrepareForShutdown api, this will not only monitor in_progress asynchronous jobs and wait for its completion and prevent addition of new asynchronous jobs.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1222173571
Hi @Yashikaone thanks for your PR, I can see your changes on the second commit, however the first commit is not needed since there are no changes on it, can you please amend the PR to reflect only your changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1223646028
@Yashikaone , you should completely remove commit `ce70939f3a3aeb9d0c7f0dda10aa5e531c461691` from your PR.
As the current status is you can do that by entering the command
`git rebase -i HEAD~5` and then in the editor you get presented remove the line for that commit from the file. Git will remnove the commit. After the complete procedure check the result. You can then `git push -- force` and the commit with all the empty changes will be gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1228126470
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6662 (SL-JID-2231)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1228122006
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1228122513
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6662: Feature x
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1514266059
This was superseeded by https://github.com/apache/cloudstack/pull/6755 closing on this remark. Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1222093506
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Yashikaone commented on pull request #6662: Feature x
Posted by GitBox <gi...@apache.org>.
Yashikaone commented on PR #6662:
URL: https://github.com/apache/cloudstack/pull/6662#issuecomment-1222340332
@nvazquez Sure , I'll find a way to fix that. Can you look into the changes and let me know how can I get this correct?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6662: Feature x
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud closed pull request #6662: Feature x
URL: https://github.com/apache/cloudstack/pull/6662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org