You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/26 23:12:17 UTC
Review Request 67751: WIP: Added missing files to CMake build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
Repository: mesos
Description
-------
WIP: Added missing files to CMake build.
Diffs
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
src/python/executor/CMakeLists.txt PRE-CREATION
src/python/scheduler/CMakeLists.txt PRE-CREATION
src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
Diff: https://reviews.apache.org/r/67751/diff/1/
Testing
-------
This does not add the `option(FOO)` yet to the configuration, not is there logic (yet) to find the necessary libraries to enable those options. How do we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may honestly take just as much time to add the `find_library` logic myself...
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67751: WIP: Added missing files to CMake build.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review205408
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67751]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 26, 2018, 11:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 11:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing files to CMake build.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
>
>
> Diff: https://reviews.apache.org/r/67751/diff/1/
>
>
> Testing
> -------
>
> This does not add the `option(FOO)` yet to the configuration, not is there logic (yet) to find the necessary libraries to enable those options. How do we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may honestly take just as much time to add the `find_library` logic myself...
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: WIP: Added missing files to CMake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review205403
-----------------------------------------------------------
src/Makefile.am
Lines 2711-2718 (original), 2711-2718 (patched)
<https://reviews.apache.org/r/67751/#comment288291>
This was backwards from where it was first declared.
- Andrew Schwartzmeyer
On June 26, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 4:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing files to CMake build.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
>
>
> Diff: https://reviews.apache.org/r/67751/diff/1/
>
>
> Testing
> -------
>
> This does not add the `option(FOO)` yet to the configuration, not is there logic (yet) to find the necessary libraries to enable those options. How do we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may honestly take just as much time to add the `find_library` logic myself...
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: WIP: Added missing files to CMake build.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review205406
-----------------------------------------------------------
FAIL: Mesos binaries failed to build.
Reviews applied: `['67751']`
Failed command: `cmake.exe --build . --config Release -- /maxcpucount`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67751
Relevant logs:
- [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67751/logs/mesos-binaries-cmake-stdout.log):
```
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\master\mesos-master.vcxproj" (default target) (43) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\master\mesos-master.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj" (default target) (39) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj" (default target) (46) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (32) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\cli\mesos-cli.vcxproj" (default target) (36) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\cli\mesos.cpp(17): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory [D:\DCOS\mesos\src\cli\mesos-cli.vcxproj]
506 Warning(s)
1 Error(s)
Time Elapsed 00:26:33.98
```
- Mesos Reviewbot Windows
On June 26, 2018, 11:12 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 11:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing files to CMake build.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
>
>
> Diff: https://reviews.apache.org/r/67751/diff/1/
>
>
> Testing
> -------
>
> This does not add the `option(FOO)` yet to the configuration, not is there logic (yet) to find the necessary libraries to enable those options. How do we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may honestly take just as much time to add the `find_library` logic myself...
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: WIP: Added missing files to CMake build.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review206272
-----------------------------------------------------------
This looks overall good to me.
This patch adds some cmake options which can be enabled on the command line, but do suprising things (e.g., add files depending on non-existant 3rdparty deps which also rely on unset preprocessor symbols). I'd suggest to explicitly check that the options are not enabled. This could be a simple
if (ENABLE_PORT_MAPPING_ISOLATOR)
message(FATAL "The cmake build currently does not support the port mapping isolator, see MESOS-XYZ")
endif ()
src/CMakeLists.txt
Lines 317 (patched)
<https://reviews.apache.org/r/67751/#comment289169>
In the autotools build this triggers a `#define ENABLE_XFS_DISK_ISOLATOR`.
src/CMakeLists.txt
Lines 339 (patched)
<https://reviews.apache.org/r/67751/#comment289170>
In the autotools build this triggers a `#define ENABLE_NETWORK_PORTS_ISOLATOR`.
src/CMakeLists.txt
Lines 344 (patched)
<https://reviews.apache.org/r/67751/#comment289171>
In the autotools build this triggers a `#define ENABLE_PORT_MAPPING_ISOLATOR`.
src/CMakeLists.txt
Lines 604-605 (patched)
<https://reviews.apache.org/r/67751/#comment289168>
Let's remove the comments. They add nothing on this level and would hopefully get out of sync anyway.
src/cli/CMakeLists.txt
Lines 33-40 (patched)
<https://reviews.apache.org/r/67751/#comment289167>
Simple and reasonable!
- Benjamin Bannier
On June 27, 2018, 1:12 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 1:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing files to CMake build.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
>
>
> Diff: https://reviews.apache.org/r/67751/diff/1/
>
>
> Testing
> -------
>
> This does not add the `option(FOO)` yet to the configuration, not is there logic (yet) to find the necessary libraries to enable those options. How do we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may honestly take just as much time to add the `find_library` logic myself...
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: Add missing files to CMake build.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review206735
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 28, 2018, 12:26 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated July 28, 2018, 12:26 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds stubs for the Python executor and scheduler, adds
> support for `mesos-resolve`, adds conditional support for the old
> `mesos-cli` when `ENABLE_NEW_CLI` is not set and not on Windows, and
> fixes some ordering oddities.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
>
>
> Diff: https://reviews.apache.org/r/67751/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67751: Add missing files to CMake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
-----------------------------------------------------------
(Updated July 27, 2018, 3:26 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
Changes
-------
Fix to not break on Windows.
Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994
Repository: mesos
Description (updated)
-------
This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set and not on Windows, and
fixes some ordering oddities.
Diffs (updated)
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
src/python/executor/CMakeLists.txt PRE-CREATION
src/python/scheduler/CMakeLists.txt PRE-CREATION
src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
Diff: https://reviews.apache.org/r/67751/diff/3/
Changes: https://reviews.apache.org/r/67751/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67751: Add missing files to CMake build.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/
-----------------------------------------------------------
(Updated July 27, 2018, 12:10 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, James Peach, and Joseph Wu.
Changes
-------
Split out unrelated changes and addressed review.
Summary (updated)
-----------------
Add missing files to CMake build.
Bugs: MESOS-8994
https://issues.apache.org/jira/browse/MESOS-8994
Repository: mesos
Description (updated)
-------
This patch adds stubs for the Python executor and scheduler, adds
support for `mesos-resolve`, adds conditional support for the old
`mesos-cli` when `ENABLE_NEW_CLI` is not set, and fixes some ordering
oddities.
Diffs (updated)
-----
src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9
src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
src/python/executor/CMakeLists.txt PRE-CREATION
src/python/scheduler/CMakeLists.txt PRE-CREATION
src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4
Diff: https://reviews.apache.org/r/67751/diff/2/
Changes: https://reviews.apache.org/r/67751/diff/1-2/
Testing (updated)
-------
Thanks,
Andrew Schwartzmeyer