You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Olaf Sebelin (JIRA)" <ji...@apache.org> on 2007/06/12 11:01:33 UTC
[jira] Created: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Custom Protocol in HostConfiguration ignored
--------------------------------------------
Key: HTTPCLIENT-658
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient
Affects Versions: 3.1 RC1
Reporter: Olaf Sebelin
If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-658.
------------------------------------------
Resolution: Won't Fix
Marking as WONTFIX
Oleg
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Priority: Minor
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503847 ]
Oleg Kalnichevski commented on HTTPCLIENT-658:
----------------------------------------------
Olaf,
Test case looks reasonable to me.
Folks
Any objections to committing this patch? I was always very reluctant to make this change because it addresses the problem caused by a clear abuse of the API, but given the fact API is known to be bad and the patch appears to have no side effects, I am in favor of accepting this patch.
If I hear no load objections, I'll commit the patch in a few days
Oleg
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber updated HTTPCLIENT-658:
------------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
Firstly, this is not a bug. It has been documented several times on the mailing list and in the bug tracking system that setting the scheme handler in the HostConfiguration will only work for relative URLs. Bugs are deviations from intended or documented behavior, not things that work differently from what somebody expected. This is a feature request, and I'll grant that it is an improvement.
Secondly, this is not major. As far as I can tell, in HTTPCLIENT-634 John Kristian provided us with a solution to this problem that does not affect the default behavior. A previous lack of test coverage is not a good argument for changing default behavior that late in the release cycle.
Before I agree to this change, I would like to see discussion of two questions:
1) What and how many applications might be affected by this change? Over the years, we've told a lot of people that it will only work for relative URLs. Has anyone written an application that _relies_ on this behavior?
2) If we apply this patch, how can an application switch back to the current behavior? Ignoring a method call by providing a custom HostConfiguration implementation is easy, but how do you act on a method _not_ being called?
The second question is independent of the first one. Even if we can't think of any reason for an application to rely on the scheme handler being reset, we must not change the behavior between RC1 and final unless we can tell people how to get back to the original one. Respectfully, I am -0 on this change.
cheers,
Roland
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Priority: Minor
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505350 ]
Ortwin Glück commented on HTTPCLIENT-658:
-----------------------------------------
I agree with Roland. The change may stab projects in the back unexpectedly. Olaf should patch his local copy and wait for 4.0.
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Priority: Minor
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Olaf Sebelin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olaf Sebelin updated HTTPCLIENT-658:
------------------------------------
Attachment: patch.txt
This patch keeps the Protocol attached to a HostConfig, if the scheme is the same as in the URL.
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Attachments: patch.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-658:
-----------------------------------------
Fix Version/s: 3.1 Final
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Fix For: 3.1 Final
>
> Attachments: patch.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Closed: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Olaf Sebelin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olaf Sebelin closed HTTPCLIENT-658.
-----------------------------------
OK, will do that. Thank you.
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Priority: Minor
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503793 ]
Oleg Kalnichevski commented on HTTPCLIENT-658:
----------------------------------------------
Olaf,
Please also consider submitting a test case for this issue. This will increase the chances of the patch getting committed sooner rather then later
Oleg
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Fix For: 3.1 Final
>
> Attachments: patch.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Updated: (HTTPCLIENT-658) Custom Protocol in
HostConfiguration ignored
Posted by "Olaf Sebelin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olaf Sebelin updated HTTPCLIENT-658:
------------------------------------
Attachment: patch_TestHostConfiguration.txt
Added a Test for the patch to org.apache.commons.httpclient.TestHostConfiguration.
> Custom Protocol in HostConfiguration ignored
> --------------------------------------------
>
> Key: HTTPCLIENT-658
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-658
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 3.1 RC1
> Reporter: Olaf Sebelin
> Fix For: 3.1 Final
>
> Attachments: patch.txt, patch_TestHostConfiguration.txt
>
>
> If you you do not register a custom Protocol as scheme default handler but set it in HostConfiguration, it will be ignored if the URL given to a Method instance is absolute.
> HttpClient will then override it by calling hostconfig.setHost(uri).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org