You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Dawid Weiss <da...@gmail.com> on 2024/08/30 10:39:05 UTC
Heads up: Gradle upgrade
Just a kind note that this PR, updating gradle, has been folded into the
main branch:
https://github.com/apache/lucene/issues/13698
It wasn't a smooth ride so if you experience something odd or not working,
please add a comment or reopen that issue. Thank you.
Dawid
Re: Heads up: Gradle upgrade
Posted by Chris Hegarty <ch...@elastic.co.INVALID>.
> On 31 Aug 2024, at 16:51, Dawid Weiss <da...@gmail.com> wrote:
>
>
> I've added jdk 23-ea to this gh action:
> https://github.com/apache/lucene/actions/runs/10641649862
Excellent. Thank you.
-Chris.
>
> D.
>
> On Fri, Aug 30, 2024 at 5:52 PM Chris Hegarty <ch...@elastic.co.invalid> wrote:
> Hi Uwe,
>
> > On 30 Aug 2024, at 15:31, Uwe Schindler <uw...@thetaphi.de> wrote:
> >
> > I agree, smoke tester is not easy. This is on TODO list for me. I am happy that you can pass multiple JDKs in a single command line and then it works for 2 hours. But yes, I was not able to run smoker on Java 22 or Java 23 up to now on Policeman Jenkins's Smoke tester task when a new release was made.
>
> I’ve not tried, but now that we’re on the latest Gradle it should work as is for JDK 22 and JDK 23. :fingers_crossed:
>
> -Chris.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Heads up: Gradle upgrade
Posted by Dawid Weiss <da...@gmail.com>.
I've added jdk 23-ea to this gh action:
https://github.com/apache/lucene/actions/runs/10641649862
D.
On Fri, Aug 30, 2024 at 5:52 PM Chris Hegarty
<ch...@elastic.co.invalid> wrote:
> Hi Uwe,
>
> > On 30 Aug 2024, at 15:31, Uwe Schindler <uw...@thetaphi.de> wrote:
> >
> > I agree, smoke tester is not easy. This is on TODO list for me. I am
> happy that you can pass multiple JDKs in a single command line and then it
> works for 2 hours. But yes, I was not able to run smoker on Java 22 or Java
> 23 up to now on Policeman Jenkins's Smoke tester task when a new release
> was made.
>
> I’ve not tried, but now that we’re on the latest Gradle it should work as
> is for JDK 22 and JDK 23. :fingers_crossed:
>
> -Chris.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Heads up: Gradle upgrade
Posted by Chris Hegarty <ch...@elastic.co.INVALID>.
Hi Uwe,
> On 30 Aug 2024, at 15:31, Uwe Schindler <uw...@thetaphi.de> wrote:
>
> I agree, smoke tester is not easy. This is on TODO list for me. I am happy that you can pass multiple JDKs in a single command line and then it works for 2 hours. But yes, I was not able to run smoker on Java 22 or Java 23 up to now on Policeman Jenkins's Smoke tester task when a new release was made.
I’ve not tried, but now that we’re on the latest Gradle it should work as is for JDK 22 and JDK 23. :fingers_crossed:
-Chris.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Heads up: Gradle upgrade
Posted by Uwe Schindler <uw...@thetaphi.de>.
I agree, smoke tester is not easy. This is on TODO list for me. I am
happy that you can pass multiple JDKs in a single command line and then
it works for 2 hours. But yes, I was not able to run smoker on Java 22
or Java 23 up to now on Policeman Jenkins's Smoke tester task when a new
release was made.
Uwe
Am 30.08.2024 um 15:51 schrieb Chris Hegarty:
> Hi Uwe,
>
>> On 30 Aug 2024, at 14:40, Uwe Schindler <uw...@thetaphi.de> wrote:
>>
>> Hi,
>>
>> Testing with JDK 23 is trivial, you don't need an updated Gradle, I have a shortcut for this setup on my explorer toolbar that launches a shell with the given settings (on every possible JDK installed her)
>>
>> export RUNTIME_JAVA_HOME=/path/to/jdk/23,24,25,43,....
>> ./gradlew test
> Agreed.
>
> I was mostly thinking about the release validation smoke test, where I thought there was a small complication whereby it used the same JDK for both running gradle and the tests. But maybe that is no longer an issue. ( I basically wanna be able to run `python3 -u dev-tools/scripts/smokeTestRelease.py ` on Lucene 9.12 and 10 RC builds with JDK 23 )
>
> -Chris.
>
>> Uwe
>>
>> Am 30.08.2024 um 13:00 schrieb Chris Hegarty:
>>>> On 30 Aug 2024, at 11:39, Dawid Weiss <da...@gmail.com> wrote:
>>>>
>>>>
>>>> Just a kind note that this PR, updating gradle, has been folded into the main branch:
>>>>
>>>> https://github.com/apache/lucene/issues/13698
>>>>
>>>> It wasn't a smooth ride so if you experience something odd or not working, please add a comment or reopen that issue. Thank you.
>>> Thanks for doing this, your efforts are very much appreciated.
>>>
>>> Once it settles a bit in _main_, it would be great to backport to 9.x so we can more easily test and verify with JDK 23 builds.
>>>
>>> -Chris.
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>> --
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremen
>> https://www.thetaphi.de
>> eMail: uwe@thetaphi.de
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Heads up: Gradle upgrade
Posted by Chris Hegarty <ch...@elastic.co.INVALID>.
Hi Uwe,
> On 30 Aug 2024, at 14:40, Uwe Schindler <uw...@thetaphi.de> wrote:
>
> Hi,
>
> Testing with JDK 23 is trivial, you don't need an updated Gradle, I have a shortcut for this setup on my explorer toolbar that launches a shell with the given settings (on every possible JDK installed her)
>
> export RUNTIME_JAVA_HOME=/path/to/jdk/23,24,25,43,....
> ./gradlew test
Agreed.
I was mostly thinking about the release validation smoke test, where I thought there was a small complication whereby it used the same JDK for both running gradle and the tests. But maybe that is no longer an issue. ( I basically wanna be able to run `python3 -u dev-tools/scripts/smokeTestRelease.py ` on Lucene 9.12 and 10 RC builds with JDK 23 )
-Chris.
> Uwe
>
> Am 30.08.2024 um 13:00 schrieb Chris Hegarty:
>>> On 30 Aug 2024, at 11:39, Dawid Weiss <da...@gmail.com> wrote:
>>>
>>>
>>> Just a kind note that this PR, updating gradle, has been folded into the main branch:
>>>
>>> https://github.com/apache/lucene/issues/13698
>>>
>>> It wasn't a smooth ride so if you experience something odd or not working, please add a comment or reopen that issue. Thank you.
>> Thanks for doing this, your efforts are very much appreciated.
>>
>> Once it settles a bit in _main_, it would be great to backport to 9.x so we can more easily test and verify with JDK 23 builds.
>>
>> -Chris.
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
> --
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> https://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Heads up: Gradle upgrade
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi,
Testing with JDK 23 is trivial, you don't need an updated Gradle, I have
a shortcut for this setup on my explorer toolbar that launches a shell
with the given settings (on every possible JDK installed her)
export RUNTIME_JAVA_HOME=/path/to/jdk/23,24,25,43,....
./gradlew test
Uwe
Am 30.08.2024 um 13:00 schrieb Chris Hegarty:
>> On 30 Aug 2024, at 11:39, Dawid Weiss <da...@gmail.com> wrote:
>>
>>
>> Just a kind note that this PR, updating gradle, has been folded into the main branch:
>>
>> https://github.com/apache/lucene/issues/13698
>>
>> It wasn't a smooth ride so if you experience something odd or not working, please add a comment or reopen that issue. Thank you.
> Thanks for doing this, your efforts are very much appreciated.
>
> Once it settles a bit in _main_, it would be great to backport to 9.x so we can more easily test and verify with JDK 23 builds.
>
> -Chris.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
Uwe Schindler
Achterdiek 19, D-28357 Bremen
https://www.thetaphi.de
eMail: uwe@thetaphi.de
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Heads up: Gradle upgrade
Posted by Dawid Weiss <da...@gmail.com>.
> Once it settles a bit in _main_, it would be great to backport to 9.x so
> we can more easily test and verify with JDK 23 builds.
>
+1. I'll add a calendar entry in a week or so.
D.
Re: Heads up: Gradle upgrade
Posted by Chris Hegarty <ch...@elastic.co.INVALID>.
> On 30 Aug 2024, at 11:39, Dawid Weiss <da...@gmail.com> wrote:
>
>
> Just a kind note that this PR, updating gradle, has been folded into the main branch:
>
> https://github.com/apache/lucene/issues/13698
>
> It wasn't a smooth ride so if you experience something odd or not working, please add a comment or reopen that issue. Thank you.
Thanks for doing this, your efforts are very much appreciated.
Once it settles a bit in _main_, it would be great to backport to 9.x so we can more easily test and verify with JDK 23 builds.
-Chris.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org