You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/28 12:46:19 UTC

[GitHub] [zookeeper] BELUGABEHR commented on a change in pull request #876: Zookeeper 3020 2

BELUGABEHR commented on a change in pull request #876: Zookeeper 3020 2
URL: https://github.com/apache/zookeeper/pull/876#discussion_r269982741
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
 ##########
 @@ -117,48 +118,46 @@ public void run() {
                 if (si == requestOfDeath) {
                     break;
                 }
-                if (si != null) {
 
 Review comment:
   This looks like a lot of code change, but I simply removed this check 'is null' check and subsequently had to fix the indentation of the large block of code beneath it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services