You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/29 20:52:54 UTC

[jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Note only last commit is new.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs adrian.decomplicate-test

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs/pull/107

-- Commit Summary --

  * Remove tar creation responsibility from docker, avoiding filesystem bias.
  * Decomplicate consuming the output of docker commands in tests.

-- File Changes --

    M docker/pom.xml (12)
    D docker/src/main/java/org/jclouds/docker/binders/BindInputStreamToRequest.java (68)
    M docker/src/main/java/org/jclouds/docker/features/RemoteApi.java (16)
    D docker/src/main/java/org/jclouds/docker/features/internal/Archives.java (60)
    D docker/src/test/java/org/jclouds/docker/binders/BindInputStreamToRequestTest.java (67)
    M docker/src/test/java/org/jclouds/docker/compute/BaseDockerApiLiveTest.java (65)
    M docker/src/test/java/org/jclouds/docker/features/RemoteApiLiveTest.java (36)
    M docker/src/test/java/org/jclouds/docker/features/RemoteApiMockTest.java (39)
    D docker/src/test/java/org/jclouds/docker/features/internal/ArchivesTest.java (112)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/107.patch
https://github.com/jclouds/jclouds-labs/pull/107.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1841](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1841/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-61205205

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by Adrian Cole <no...@github.com>.
PS I'm not entirely sure the value of these apis returning an inputstream. Is there a scenario where this is not a character stream?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-60996213

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by Adrian Cole <no...@github.com>.
Closed #107.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#event-186371428

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #370](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/370/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-61204471

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by Adrian Cole <no...@github.com>.
@demobox 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-61203950

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1828](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1828/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-60994310

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #367](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/367/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-60992763

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #368](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/368/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-60994841

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1829](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1829/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-60997343

Re: [jclouds-labs] Decomplicate consuming the output of docker commands in tests. (#107)

Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/107#issuecomment-61215456