You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/17 07:13:05 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3947: [ISSUE #3946]Add unit test method or class for classes: NetUtils, TopicResponse
pandaapo opened a new pull request, #3947:
URL: https://github.com/apache/eventmesh/pull/3947
Fixes ##3946.
### Motivation
Import code coverage of NetUtils, TopicResponse.
### Modifications
Add test methods of `NetUtils#sendSuccessResponseHeaders()`.
Add test class for `TopicResponse`.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3947: [ISSUE #3946]Add unit test method or class for classes: NetUtils, TopicResponse
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3947:
URL: https://github.com/apache/eventmesh/pull/3947#issuecomment-1556417938
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3947](https://app.codecov.io/gh/apache/eventmesh/pull/3947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a795f7) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/ef917b9c5ae198bec3f2ebbf777fa75687803808?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ef917b9) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 4a795f7 differs from pull request most recent head a702404. Consider uploading reports for the commit a702404 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3947 +/- ##
============================================
- Coverage 13.93% 13.89% -0.05%
- Complexity 1291 1294 +3
============================================
Files 571 578 +7
Lines 28803 28915 +112
Branches 2807 2800 -7
============================================
+ Hits 4015 4017 +2
- Misses 24413 24523 +110
Partials 375 375
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...col/http/resolver/HttpRequestProtocolResolver.java](https://app.codecov.io/gh/apache/eventmesh/pull/3947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXByb3RvY29sLXBsdWdpbi9ldmVudG1lc2gtcHJvdG9jb2wtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3Byb3RvY29sL2h0dHAvcmVzb2x2ZXIvSHR0cFJlcXVlc3RQcm90b2NvbFJlc29sdmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3947/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3947: [ISSUE #3946]Add unit test method or class for classes: NetUtils, TopicResponse
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3947:
URL: https://github.com/apache/eventmesh/pull/3947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org