You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/09/08 01:26:57 UTC

[jira] Created: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Decide if we should remove lines numbers from latest Changes
------------------------------------------------------------

                 Key: LUCENE-1898
                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Other
            Reporter: Mark Miller
             Fix For: 2.9


As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.

I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.

I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).

If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Issue Comment Edited: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752286#action_12752286 ] 

Steven Rowe edited comment on LUCENE-1898 at 9/7/09 8:56 PM:
-------------------------------------------------------------

{{changes2html.pl}} doesn't fully grok the new format - items are numbered, but the asterisks are left in in some cases.  I'll work up a patch.

      was (Author: steve_rowe):
    {{changes-to-html.pl}} doesn't fully grok the new format - items are numbered, but the asterisks are left in in some cases.  I'll work up a patch.
  
> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752291#action_12752291 ] 

Robert Muir commented on LUCENE-1898:
-------------------------------------

contrib/benchmark CHANGES has a different format (dates instead of numbers), and maybe do this for contrib/CHANGES too?


> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752372#action_12752372 ] 

Shai Erera commented on LUCENE-1898:
------------------------------------

+1. makes sense. Even in the HTML I don't think it's necessary for the changes to be numbered. Bullets will also work for me.

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller resolved LUCENE-1898.
---------------------------------

       Resolution: Fixed
         Assignee: Mark Miller
    Lucene Fields: [New, Patch Available]  (was: [New])

Thanks a million Steve!

r812493

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-1898:
--------------------------------

    Attachment: LUCENE-1898.patch

Patch to changes2html.pl that can handle '*' as bulleted item indicator.  Also converts numbered items in contrib/CHANGES.txt for 2.9 release to '*' bullets.  

This patch incorporates Mark's numbered->bulleted modifications to CHANGES.txt, as well as correcting one numbered item that Mark missed, and converting tabs to spaces in the first <code> section, so that the method parameters line up in the output HTML.

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Issue Comment Edited: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752323#action_12752323 ] 

Steven Rowe edited comment on LUCENE-1898 at 9/7/09 8:55 PM:
-------------------------------------------------------------

Patch to changes2html.pl that can handle '\*' as bulleted item indicator.  Also converts numbered items in contrib/CHANGES.txt for 2.9 release to '\*' bullets.  

This patch incorporates Mark's numbered->bulleted modifications to CHANGES.txt, as well as correcting one numbered item that Mark missed, and converting tabs to spaces in the first <code> section, so that the method parameters line up in the output HTML.

      was (Author: steve_rowe):
    Patch to changes2html.pl that can handle '*' as bulleted item indicator.  Also converts numbered items in contrib/CHANGES.txt for 2.9 release to '*' bullets.  

This patch incorporates Mark's numbered->bulleted modifications to CHANGES.txt, as well as correcting one numbered item that Mark missed, and converting tabs to spaces in the first <code> section, so that the method parameters line up in the output HTML.
  
> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752459#action_12752459 ] 

Uwe Schindler commented on LUCENE-1898:
---------------------------------------

+1 That would be really nice. We always have this duplicate numbers, cascading renumbering and so on. I think, numbering of items is part of the presentation layer (like in XHTML where you have numbered lists)

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752294#action_12752294 ] 

Yonik Seeley commented on LUCENE-1898:
--------------------------------------

+1, makes sense.

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752286#action_12752286 ] 

Steven Rowe commented on LUCENE-1898:
-------------------------------------

{{changes-to-html.pl}} doesn't fully grok the new format - items are numbered, but the asterisks are left in in some cases.  I'll work up a patch.

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752397#action_12752397 ] 

Michael McCandless commented on LUCENE-1898:
--------------------------------------------

+1

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch, LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1898) Decide if we should remove lines numbers from latest Changes

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated LUCENE-1898:
--------------------------------

    Attachment: LUCENE-1898.patch

> Decide if we should remove lines numbers from latest Changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-1898
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1898
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Other
>            Reporter: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1898.patch
>
>
> As Lucene dev has grown, a new issue has arisen - many times, new changes invalidate old changes. A proper changes file should just list the changes from the last version, not document the dev life of the issues. Keeping changes in proper order now requires a lot of renumbering sometimes. The numbers have no real meaning and could be added to more rich versions (such as the html version) automatically if desired.
> I think an * makes a good replacement myself. The issues already have ids that are stable, rather than the current, decorational numbers which are subject to change over a dev cycle.
> I think we should replace the numbers with an asterix for the 2.9 section and going forward (ie 4. becomes *).
> If we don't get consensus very quickly, this issue won't block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org