You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/04/22 20:16:22 UTC

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24225


Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................

IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success

TestHS2.test_long_polling_success verifies the timing of
operations with long polling. It is testing that a certain
call takes more than 80ms and less than 1 second. We've
seen flakiness for both of these bounds, so this loosens
them to 50ms and 4 seconds. These still verify that long
polling is functioning.

Testing:
 - Ran locally for 1000 iterations

Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
---
M tests/hs2/test_hs2.py
1 file changed, 7 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/24225/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1:

Maven build flakiness. I'm going to rerun.


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 04:36:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13373/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 04:36:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................

IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

TestHS2 has a couple tests that verify the timing of
operations with long polling. Specifically, both
test_long_polling_success and test_long_polling_failure
expect the call to take less than a second when using
a long_polling_time_ms of 10000. We've seen flakiness
for both of these test cases, so this loosens the bound
to 4 seconds. This is still enough to verify that long
polling is functioning.

Testing:
 - Ran locally for 1000 iterations

Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Reviewed-on: http://gerrit.cloudera.org:8080/24225
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/hs2/test_hs2.py
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:25:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13369/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 20:43:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 08:51:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 15:32:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13369/


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2026 01:06:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24225

to look at the new patch set (#2).

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................

IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

TestHS2 has a couple tests that verify the timing of
operations with long polling. Specifically, both
test_long_polling_success and test_long_polling_failure
expect the call to take less than a second when using
a long_polling_time_ms of 10000. We've seen flakiness
for both of these test cases, so this loosens the bound
to 4 seconds. This is still enough to verify that long
polling is functioning.

Testing:
 - Ran locally for 1000 iterations

Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
---
M tests/hs2/test_hs2.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/24225/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13418/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:25:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2026 20:25:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466: Fix flakiness in TestHS2.test long polling success

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466: Fix flakiness in TestHS2.test_long_polling_success
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22214/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2026 20:39:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22274/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Apr 2026 17:37:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24225 )

Change subject: IMPALA-13466/IMPALA-14935: Fix flakiness in TestHS2 long polling tests
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24225
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I401e972bf9dd71dd0c8c11f9dbf575d3ed09b245
Gerrit-Change-Number: 24225
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 May 2026 00:53:54 +0000
Gerrit-HasComments: No